Skip to content

[Routine - VT] fix(commands): clamp bookmark position to document bounds in jumpToBookmark #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
winterdrive wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Routine - VT] fix(commands): clamp bookmark position to document bounds in jumpToBookmark #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,10 +1188,13 @@ export function registerCommands(
const document = await vscode.workspace.openTextDocument(item.fileUri);
const editor = await vscode.window.showTextDocument(document);

const position = new vscode.Position(
// Clamp to the document's current bounds: the file may have been
// edited (lines removed) since the bookmark was created, which would
// otherwise leave selection/reveal operating on an invalid position.
const position = document.validatePosition(new vscode.Position(
item.bookmark.line,
item.bookmark.character || 0
);
));

const range = new vscode.Range(position, position);

Expand Down
Loading