Skip to content

docs(devcontainer): update README for PHP 8.4 and FrankenPHP#1476

Merged
LukeTowers merged 1 commit intowintercms:developfrom
matteotrubini:docs/devcontainer
Apr 7, 2026
Merged

docs(devcontainer): update README for PHP 8.4 and FrankenPHP#1476
LukeTowers merged 1 commit intowintercms:developfrom
matteotrubini:docs/devcontainer

Conversation

@matteotrubini
Copy link
Copy Markdown
Contributor

@matteotrubini matteotrubini commented Apr 6, 2026

Update devcontainer README to align with Winter CMS Docker image migration from Apache 2 to FrankenPHP

Summary by CodeRabbit

  • Documentation
    • Updated development environment from Apache 2.4 with PHP 8.3 to FrankenPHP (Caddy) with PHP 8.4
    • Upgraded Node.js from version 22 to 24
    • Updated development container configuration examples and reference documentation links

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Walkthrough

This pull request updates the .devcontainer/README.md file to reflect infrastructure changes. The development runtime description is updated from Apache 2.4 with PHP 8.3 to FrankenPHP (Caddy) with PHP 8.4. Node.js version is incremented from 22 to 24. The sample devcontainer configuration is modified by removing Apache-related features and replacing them with common-utils and github-cli, while also removing the overrideFeatureInstallOrder configuration block. Documentation links are redirected to point to the Winter Docker image README persist-data section and FrankenPHP environment variables documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main changes: updating documentation for PHP 8.4 and migration to FrankenPHP, which aligns with the actual file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.devcontainer/README.md:
- Around line 48-53: The example in the "features" JSON leaves the bootstrap
feature enabled even though the text says to disable it; update the example so
the "./local-features/bootstrap-winter": "latest" entry is commented out or
removed from the "features" block (or shown as disabled) to match the
instruction, and ensure the README's example and the note about disabling
bootstrap-winter reference the same state; target the "features" object and the
"./local-features/bootstrap-winter" entry when making this change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 277bc739-ae95-4afb-bd12-603b1a4b7fdf

📥 Commits

Reviewing files that changed from the base of the PR and between 5391afa and 3850247.

📒 Files selected for processing (1)
  • .devcontainer/README.md

Comment on lines +48 to 53
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {},
"ghcr.io/devcontainers/features/github-cli:1": {},
// Comment the following feature if you wish to bootstrap and configure Winter manually (ie. you wish to use this for your own project)
//"./local-features/bootstrap-winter": "latest"
"./local-features/bootstrap-winter": "latest"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Example contradicts “disable bootstrap-winter” instruction

Line 45 says to disable by commenting out the feature, but Line 52 still shows ./local-features/bootstrap-winter enabled in the example. This can mislead users into keeping bootstrap enabled.

Suggested doc fix
     "features": {
         "ghcr.io/devcontainers/features/common-utils:2": {},
         "ghcr.io/devcontainers/features/github-cli:1": {},
         // Comment the following feature if you wish to bootstrap and configure Winter manually (ie. you wish to use this for your own project)
-        "./local-features/bootstrap-winter": "latest"
+        // "./local-features/bootstrap-winter": "latest"
     },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {},
"ghcr.io/devcontainers/features/github-cli:1": {},
// Comment the following feature if you wish to bootstrap and configure Winter manually (ie. you wish to use this for your own project)
//"./local-features/bootstrap-winter": "latest"
"./local-features/bootstrap-winter": "latest"
},
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {},
"ghcr.io/devcontainers/features/github-cli:1": {},
// Comment the following feature if you wish to bootstrap and configure Winter manually (ie. you wish to use this for your own project)
// "./local-features/bootstrap-winter": "latest"
},
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.devcontainer/README.md around lines 48 - 53, The example in the "features"
JSON leaves the bootstrap feature enabled even though the text says to disable
it; update the example so the "./local-features/bootstrap-winter": "latest"
entry is commented out or removed from the "features" block (or shown as
disabled) to match the instruction, and ensure the README's example and the note
about disabling bootstrap-winter reference the same state; target the "features"
object and the "./local-features/bootstrap-winter" entry when making this
change.

@LukeTowers LukeTowers merged commit 0758670 into wintercms:develop Apr 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants