Feature: custom wine binary path per bottle #42
Conversation
|
Incidentally, I think this feature also (partly?) solves the problem in issue 22 on your GitLab instance. |
|
Thank you for your PR and joining github. Development is mainly taking place on my gitlab instance however, but that doesn't matter too much for now (although I could give you an account). This is just a mirror after all. You won't be able to merge PRs here. Its quite a big change and it was indeed part of the planning to support this feature. So thank you once again for taking the time to implement it yourself. Just keep in mind, there is one big MR open at the moment: https://gitlab.melroy.org/melroy/winegui/-/merge_requests/41 (which is migrating the whole code base from GTK3 to GTK4, with a lot of changes) This MR above has a bit more priority at the moment (not saying your PR is not important xD).. I'm just saying it could lead to some merge conflicts. So just that you know. Hopefully I'm soon finalize the GTK4 binaries across all the platforms and able to merge it and release a new version. Feel free to join us on Telegram as well? https://t.me/winegui And also feel free to test the GTK4 binaries (see build artifacts) for your Linux distribution, which would help me out as well to get that MR merged so we can continue with new features like this PR :) |
|
Ok, I did not yet see that MR 😆. I'll keep track of the GTK4 progress and see if I can adjust my PR when it is finished. |
|
ok I merged GTK4.. you now have conflicts (as expected). |
| void BottleEditWindow::on_select_wine_bin_path() | ||
| { | ||
| auto* folder_chooser = | ||
| new Gtk::FileChooserDialog(*this, "Choose a folder", Gtk::FileChooserAction::FILE_CHOOSER_ACTION_SELECT_FOLDER, Gtk::DialogFlags::DIALOG_MODAL); |
There was a problem hiding this comment.
File chooser dialog is now deprecated in gtk4. See other examples in my code how how to implement a file dialog now..
2 participants
Hi,
First of all I would like to thank you for your development of WineGUI. It is a really nice graphical interface on top of Wine.
Recently I came across the need for having one specific version of Wine linked to one specific bottle (wine prefix). Since WineGUI does not yet support this, I took the liberty of adding this feature myself.
In short, I added a config option to
winegui.inicalledWineBinaryPathwhich allows the user to set a specific path to a custom Wine binary. When this option is empty, the regular system Wine binary is used and WineGUI behaves as before these commits. Obviously, this path can also be changed via the GUI (see screenshots below).Furthermore, this feature should be compatible with old
winegui.inifiles where theWineBinaryPathoption is not yet present. If this option is not present, it should be detected and added towinegui.iniautomatically with an empty value (i.e. it will use the system wine binary).I tried to follow your guidelines in creating this pull request, but feel free to tell me if I did something incorrectly.
Below are some screenshots to illustrate my changes: