feat(#201): TUI session config-review screen#472
Open
windoliver wants to merge 10 commits into
Open
Conversation
ConfigReview screen between preset-select and goal-input. Editable: mode toggle, stop-condition thresholds, concurrency limits. Read-only: topology/metrics/gates summaries. Edited GroveContract threaded through ScreenState.editedConfig into createSession (persistence via #198).
The primary `grove up → n → pick preset` flow set newSessionPreset → ScreenManager mounted at initialState screen "goal-input", bypassing config-review (only reachable via Esc-back). Now the welcome pick enters at "config-review"; ScreenManager's state initializer resolves the picked preset's baseline config (falls back to goal-input when none resolvable). handleConfigReviewBack is depth-aware for the entry-screen case. Found via live grove-TUI E2E of #201.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Config Review screen between preset-select and goal-input so operators can edit a session's resolved config before launch (closes #201; follow-up to #198/#199/#200).
Flow:
preset-select → config-review → goal-input → launch-preview → runningmaxRoundsWithoutImprovement,budget.maxContributions,budget.maxWallClockSeconds,targetMetric.value), concurrency (maxActiveClaims,maxClaimsPerAgent).config-edit.ts) with validation mirroring the contract Zod bounds (budget-drop, requiredtargetMetric.value, non-finite rejection, immutable updates). The screen is a thin view over it.GroveContractthreads throughScreenState.editedConfig→createSession({config}).POST /api/sessionsnow honors a client-suppliedconfig(was silently stripped, so edits never persisted on the HTTP/Nexus backend). Purely additive — requests withoutconfigare unchanged.Keys:
j/knavigate ·eedit ·spacetoggle mode ·dreset ·Entercontinue ·Escback.Test Plan
tsc --noEmitcleanbun test src/tui— 1787 pass / 0 failconfig-editunit tests (16) — bounds, budget-drop, immutability, non-finite rejectionscreen-managerflow + persistence tests (load-bearing: reverting the wiring makes them fail)sessionsroute tests incl. new regression that client config (maxActiveClaims 9) overrides preset default (4) and persistsgrove up(bare-init) → pick preset → edit a threshold → confirm → verify edited value lands in the session recordFollow-up (not in this PR)
Server accepts the client
configopaquely (matching existingtopologyhandling, namespace-auth-gated). A camelCaseGroveContractZod schema + handler validation would close the gap where a malformed client config could reach #199 enforcement unvalidated — worth a separate issue.Spec:
docs/superpowers/specs/2026-05-30-tui-config-review-design.md· Plan:docs/superpowers/plans/2026-05-30-tui-config-review.md