Tyler Hevia Code Review

[Tyler Hevia (tylerjhevia)]

Here is an overview of my proposed changes:

• Refactor API call function:
  - Removed the Promise instantiation in getPersonList function, instead returned fetch directly,
  which already returns a promise
  - Used a catch instead of an if statement to handle unsuccessful fetch
• Changed getFirstName from arrow function to traditional function. This didn't have any effect on
  functionality, but I wanted to write getFirstName and getLastName in the same style. They do
  serve similar purposes and I think it makes sense to structure them the same way. Is it acceptable
  to use arrow functions and normal functions alongside one another, or should I try pick one syntax
  for a project and stick to it?
• Altered the shuffleList function so that the result variable is a complete copy of the original list.
  The original copy method with slice(1) excluded the first element in the list array, so I used
  Array.from() instead.
• Also added ES6 syntax to shuffleList when swapping item positions.
• The sortByLastName function was calling sortObjListByProp with firstName as the argument and then calling the reverse() method for some reason, so I called sortObjListByProp with lastName as the argument instead.
• I poked at the React view portion of the file for a while, but it was using different React syntax from what I'm accustomed to, so I didn't end up finding anything to improve. I experimented with changing the syntax of App from React.createClass to App extends React.Component, but I ran into some errors and I wasn't sure that the change would even be an improvement, so I decided to leave it as is.