WillowTree_FunctionalCodeReview#3
Open
pgrimail wants to merge 6 commits intowillowtreeapps:masterfrom
Open
Conversation
+ Add CDNs for Bootstrap and new JQuery version + Add in-line styling to rendered controls for a more readable UI
+ Replace function declaration from const to function. There was no need to use getFirstName as a parameter call, nor as a constant, thus changing to function declaration.
+ Remove slice when copying List array. When slicing, we have no need, nor want, to remove array objects. This is incorrect functionality and results in loss of data.
+ Remove validation for type & value check between search value and available names. + Add validation to be based on .includes so we now check real-time against search values. Thus, “A”, will grab any names including “A”.
+ Change calls for First/Last Name sorts to specify first/last name + Add function parameter for first/last name sort and update function to sort based on new function parameter. ** Note: Before, using .reverse() on sort last name would only sort first name descending. As this is incorrect, we need to specify first/last name sorting.
+ Add notes related to batch of commits where additional notes/explanations are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See SummaryNotes.txt for detailed explanation of changes