Adds functionality to align plots by axis values#192
Open
DavZim wants to merge 5 commits intowilkelab:masterfrom
Open
Adds functionality to align plots by axis values#192DavZim wants to merge 5 commits intowilkelab:masterfrom
DavZim wants to merge 5 commits intowilkelab:masterfrom
Conversation
|
Hi, is there any news on this functionality? I don't think it is possible with patchwork either. It would be very useful to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality that allows the user to align plots by axis values, effectively closing #173.
Note that this is using the code by Z.lin as proposed here on SO.
Both
align_plotsandplot_gridgain a new flagalign_axis = FALSE. If set to TRUE, the graphs are aligned by their axis values as well.First a quick showcase:
There are some tests added as well, but especially the tests for
align_plots()are very crude/early as I don't have enough experience with the internals of units and there are some minor differences in some elements of the units. So far I captured the printed output, which is identical. We probably want to update that.Let me know if there are tests missing and if so which ones. Also feel free to add to this.