Integrate go-music-players/mpris library for MPRIS support#58
Open
stashluk wants to merge 2 commits into
Open
Conversation
Owner
|
I'm not sure what the deal with the adapter is, but it seems a bit messy. Also could you make the PR description a little more human and less AI, thank you! |
Separate MPRIS implementation into mpris2.go Move MPRIS player interface methods from player.go to dedicated mpris2.go file. This keeps MPRIS-specific code separate while Player still implements the mpris.Player interface. Changes: - Created mpris2.go with all MPRIS interface methods - Removed MPRIS methods from player.go - Player struct methods now split across files: - player.go: core player functionality - mpris2.go: MPRIS interface implementation Benefits: - Better code organization - MPRIS code isolated in one file - Easier to maintain MPRIS-specific logic - Player still directly implements mpris.Player 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
stashluk
force-pushed
the
integrate-go-music-players-mpris
branch
from
fd6caa5 to
495576a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom MPRIS with go-music-players/mpris. Helps make MPRIS behavior more consistent across Go music players.