analysis: classify minimal full-sign certificates by geometry; add tests and docs#50
analysis: classify minimal full-sign certificates by geometry; add tests and docs#50wilcompute wants to merge 7 commits intomasterfrom
Conversation
…ss-check in README and online findings
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0b5e4aed0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if not in_json.exists(): | ||
| # Build the trilinear map if missing | ||
| r = subprocess.run( |
There was a problem hiding this comment.
When artifacts/e6_f3_trilinear_map.json is absent, this helper always runs tools/build_e6_f3_trilinear_map.py without checking for its required input artifacts/canonical_su3_gauge_and_cubic.json; in a clean checkout that file is typically missing, so the subprocess raises FileNotFoundError and the test fails instead of being skipped (I reproduced this by running pytest -q tests/test_witness_certificate_classification.py tests/test_cross_script_striation_consistency.py). This makes the new test non-hermetic compared with nearby integration tests that guard missing artifacts with pytest.skip.
Useful? React with 👍 / 👎.
…pute orbits under AGL x z-affine
|
Closing as superseded by PR #51, which is the later branch in this same witness/enumerator line. |
1 participant
Adds a geometric classifier for minimal full-sign obstruction certificates, records per-candidate-space geotypes (Hessian216/AGL23) in analysis output, and adds tests and README/docs notes summarizing the findings. Includes ests/test_witness_certificate_classification.py which validates geotype metrics for both candidate spaces.