tests: cross-script striation consistency check + docs note#49
tests: cross-script striation consistency check + docs note#49wilcompute wants to merge 1 commit intomasterfrom
Conversation
…ss-check in README and online findings
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53a7770ed1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| out_md = root / "artifacts" / "e6_f3_trilinear_symmetry_breaking.md" | ||
|
|
||
| # Ensure analysis output exists (run analyzer if needed) | ||
| if not out_json.exists(): |
There was a problem hiding this comment.
This test only executes analyze_e6_f3_trilinear_symmetry_breaking.py when artifacts/e6_f3_trilinear_symmetry_breaking.json is missing, so a stale file from an earlier run (or from different inputs) is silently reused. In that case the assertions validate cached data instead of the current e6_f3_trilinear_map.json, which can mask real regressions in the cross-script consistency check.
Useful? React with 👍 / 👎.
| assert any( | ||
| tuple(missing_point) in L for L in family |
There was a problem hiding this comment.
This assertion does not actually validate the reported distinguished direction: in AG(2,3), every point lies on exactly one line in every direction family, so any(missing_point in L for L in family) is true for any valid direction. As written, the test will still pass if distinguished_direction_all_positive is wrong but still names one of the four standard directions.
Useful? React with 👍 / 👎.
|
Closing as superseded by later branch work in this same line, ultimately consolidated in PR #51. |
1 participant
Adds an integration test ests/test_cross_script_striation_consistency.py that verifies the trilinear analysis' distinguished direction & missing AG(2,3) point match the Heisenberg H27 fiber mapping. Also records the cross-check in README.md and docs/README_EXTENSION_ONLINE_FINDINGS_2026_02_10.md.