[BREAKING CHANGE] Drop eslint 8 support, require eslint 9#145
Open
jdforrester wants to merge 1 commit intomasterfrom
Open
[BREAKING CHANGE] Drop eslint 8 support, require eslint 9#145jdforrester wants to merge 1 commit intomasterfrom
jdforrester wants to merge 1 commit intomasterfrom
Conversation
edg2s
reviewed
Feb 23, 2026
|
|
||
| const fs = require( 'fs' ); | ||
| const { mkdirp } = require( 'mkdirp' ); | ||
| const mkdirp = require( 'mkdirp' ); |
edg2s
reviewed
Feb 23, 2026
| # eslint-docgen | ||
| Automatically generate ESLint plugin documentation from rule metadata and test cases. | ||
|
|
||
| ## Requirements |
Users creating a RuleTester object will need to migrate from setting options on `parserOptions` to `languageOptions`, for which the `ecmaVersion` default has switched from '5' to 'latest', & `sourceType' from 'script' to 'module'; other config options like `env` and `parser` should be adjusted per upstream instructions at https://eslint.org/docs/latest/use/migrate-to-9.0.0. Note that there is a minor change to the test output, but I think it's acceptable. This needed us to hopefully-temporarily drop use of eslint-config-wikimedia and insted inline many of the tests into this repo; once this is released, used by all our plugins, they're upgraded and released too, and the whole stack is fixed, we might even get back to using it. Fixes #138
jdforrester
force-pushed
the
eslint-9
branch
from
24c528b to
1a4a585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users creating a RuleTester object will need to migrate from setting options on
parserOptionstolanguageOptions, for which theecmaVersiondefault has switched from '5' to 'latest', &sourceTypefrom 'script' to 'module'; other config options likeenvandparsershould be adjusted per upstream instructions at https://eslint.org/docs/latest/use/migrate-to-9.0.0.Note that there is a minor change to the test output, but I think it's acceptable (and due to the below).
This needed us to hopefully-temporarily drop use of eslint-config-wikimedia and insted inline many of the tests into this repo; once this is released, used by all our plugins, they're upgraded and released too, and the whole stack is fixed, we might even get back to using it.
Fixes #138