feat(comp): add SCompCompress and SCompDecompress#125
Open
heinermann wants to merge 2 commits into
Open
Conversation
heinermann
commented
Jun 17, 2026
| ) | ||
|
|
||
| target_compile_definitions(storm PRIVATE _CRT_SECURE_NO_WARNINGS) | ||
| target_compile_definitions(storm PRIVATE _CRT_SECURE_NO_WARNINGS __STORMLIB_NO_STATIC_LINK__) |
Contributor
Author
There was a problem hiding this comment.
Maybe pull this into a separate stormlib chore PR
| @@ -1 +1,3 @@ | |||
| add_subdirectory(stormlib-9.31) | |||
| if(NOT WHOA_TEST_STORMDLL) | |||
Contributor
Author
There was a problem hiding this comment.
Maybe pull this into a separate stormlib chore PR
| @@ -29,7 +29,7 @@ set(STORMLIB_SOURCES | |||
| file(GLOB STORMLIB_ADPCM ${STORMLIB_SRC_DIR}/adpcm/*.c ${STORMLIB_SRC_DIR}/adpcm/*.cpp) | |||
| file(GLOB STORMLIB_HUFFMAN ${STORMLIB_SRC_DIR}/huffman/*.cpp) | |||
| file(GLOB STORMLIB_JENKINS ${STORMLIB_SRC_DIR}/jenkins/*.c) | |||
| file(GLOB STORMLIB_LZMA ${STORMLIB_SRC_DIR}/lzma/*.c) | |||
| file(GLOB STORMLIB_LZMA ${STORMLIB_SRC_DIR}/lzma/C/*.c) | |||
Contributor
Author
There was a problem hiding this comment.
Maybe pull this into a separate stormlib chore PR
Contributor
Author
|
There are apparently some build issues I need to work out |
heinermann
force-pushed
the
scomp
branch
2 times, most recently
from
3d99660 to
54f846c
Compare
Contributor
Author
|
Zero clue as to why it's failing MSVC tests, WORKS ON MY MACHINE 🤷♂️🤷♂️🤷♂️🤷♂️🤷♂️ EDIT: looks like git is taking creative liberties with replacing line endings in the test data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites for reimplementing
SFile*.Uses StormLib's implementation, relies on 3 PRs sent to StormLib (patched directly in vendor directory, will replace vendor version later). Lots of testing added since StormLib does not have tests for these.
Tests
Test Generator Tool
Was originally part of this PR but I pulled it out here.
Regarding the manual StormLib patches
I think it would be best to keep the patches and then update the vendor code when the next version of StormLib drops. There are other fixes aside from the listed PRs in their main branch as well.