feat(options): add StormGetOption and StormSetOption#121
Open
heinermann wants to merge 2 commits into
Open
Conversation
heinermann
force-pushed
the
option
branch
3 times, most recently
from
710942e to
63f0923
Compare
Contributor
Author
|
I'd like to use defines for the options, just need to come up with names. EDIT: Option 8 is used in really old WoW versions, used to get/set the CD thread for SFile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WC3R option 11 (
sregunicode) is deleted (similar to the missing option 8). The behaviour ofassertlogonlyis consistent with both WoW and WC3 accounting for the deleted struct member.Work modified from thunderbrew (commit pulled): thunderbrewhq@2ffa821