chore: merge upstream

.github/issue_template.md

@@ -16,8 +16,10 @@ e.g.
 ## Description with failing test case
 
 Please describe what you are trying to do, what you expect to see, and
-what you're seeing instead. Include a code example that we can paste
-as/is into a REPL, execute, and watch fail.
+what you're seeing instead.
+
+*Important*: Please include a complete minimal code example that we
+can paste as/is into a REPL, execute, and watch fail.
 
 ## Stack traces
 

CHANGES.md

@@ -1,6 +1,70 @@
-# aws-api 0.8
+# aws-api
 
-### DEV
+## 0.8.484 / 2020-11-05
+
+* make date parsing more tolerant [#155](https://github.com/cognitect-labs/aws-api/issues/155)
+
+## 0.8.474 / 2020-08-15
+
+* fix bug decoding GetBucketPolicy response [#148](https://github.com/cognitect-labs/aws-api/issues/148)
+
+## 0.8.469 / 2020-07-10
+
+* fix bug parsing iso8601 dates with fractional seconds [#144](https://github.com/cognitect-labs/aws-api/issues/144)
+* fix memory leak when validating requests [#143](https://github.com/cognitect-labs/aws-api/issues/143)
+
+## 0.8.456 / 2020-03-27
+
+* upgrade to tools.logging-1.0.0, data.json-1.0.0, and core.async-1.0.567
+* let core.async manage the threadpool for fetching credentials and region
+  * fixes deadlock with concurrent credentials fetch [#137](https://github.com/cognitect-labs/aws-api/issues/137)
+
+## 0.8.445 / 2020-02-25
+
+* fix deadlock using composite credentials providers (e.g. assume role example) [#130](https://github.com/cognitect-labs/aws-api/issues/130)
+
+## 0.8.437 / 2020-02-14
+
+* fix issue with `invoke` hanging when no region or creds are found [#124](https://github.com/cognitect-labs/aws-api/issues/124)
+
+## 0.8.430 / 2020-02-10
+
+* upgrade to com.cognitect/http-client 0.1.104 [#115](https://github.com/cognitect-labs/aws-api/issues/115)
+* all aws clients use shared http-client, credentials-provider, and region-provider by default
+  * addresses [#109](https://github.com/cognitect-labs/aws-api/issues/109)
+  * first call to invoke takes hit of fetching region and credentials
+* `com.cognitect.aws.api/stop` will not stop the shared http-client, but stop any other instance
+
+See [Upgrade Notes](https://github.com/cognitect-labs/aws-api/blob/master/UPGRADE.md) for more
+information about upgrading to this version.
+
+## 0.8.423 / 2020-01-17
+
+* Remove dep on commons-codec [#113](https://github.com/cognitect-labs/aws-api/issues/113)
+* Convey anomaly from http-client as/is [#114](https://github.com/cognitect-labs/aws-api/issues/114)
+
+## 0.8.408 / 2019-11-25
+
+* Reduce noise from reflection warnings in java 9+ [#106](https://github.com/cognitect-labs/aws-api/issues/106)
+* Get signing region from endpoint config [#105](https://github.com/cognitect-labs/aws-api/issues/105)
+* Add documentationUrl when available [#108](https://github.com/cognitect-labs/aws-api/issues/108)
+
+## 0.8.391 / 2019-10-25
+
+* Fix: S3 HeadObject fails with large files [#97](https://github.com/cognitect-labs/aws-api/issues/97)
+  * This was fixed in cognitect/http-client 0.1.101
+* Fix concurrency 4 limit introduced in 0.8.383
+
+## ~~0.8.383 / 2019-10-24~~
+
+* Make http calls to fetch credentials async / non-blocking.
+
+## 0.8.378 / 2019-10-19
+
+* Include service full names in latest-releases.edn [#32](https://github.com/cognitect-labs/aws-api/issues/32)
+* Wrap dynamic require of protocol ns in locking form [#92](https://github.com/cognitect-labs/aws-api/issues/92)
+
+## 0.8.352 / 2019-07-26
 
 * Use custom dynaload for http-client [#88](https://github.com/cognitect-labs/aws-api/issues/88)
   * Restores compatibility with Clojure-1.9

README.md

@@ -70,9 +70,9 @@ of your choice, e.g. `com.cognitect.aws/s3`.
 To use, for example, the s3 api, add the following to deps.edn
 
 ``` clojure
-{:deps {com.cognitect.aws/api       {:mvn/version "0.8.345"}
-        com.cognitect.aws/endpoints {:mvn/version "1.1.11.592"}
-        com.cognitect.aws/s3        {:mvn/version "726.2.488.0"}}}
+{:deps {com.cognitect.aws/api       {:mvn/version "0.8.498"}
+        com.cognitect.aws/endpoints {:mvn/version "1.1.11.934"}
+        com.cognitect.aws/s3        {:mvn/version "810.2.817.0"}}}
 ```
 
 * See [latest releases](latest-releases.edn) for a list of the latest releases of
@@ -175,7 +175,7 @@ involved example using AWS STS.
 
 ## Region lookup
 
-The aws-api client looks up the region the same with the [java
+The aws-api client looks up the region the same way the [java
 SDK](https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/java-dg-region-selection.html)
 does, with an additional check for a System property named
 "aws.region" after it checks for the AWS_REGION environment variable
@@ -216,27 +216,16 @@ the `:path` in the `:endpoint-override` map.
 
 ## http-client
 
+NOTE: the behavior of `com.cognitect.aws.api/client` and `com.cognitect.aws.api/stop`
+changed as of release 0.8.430. See [Upgrade
+Notes](https://github.com/cognitect-labs/aws-api/blob/master/UPGRADE.md)
+for more information.
+
 The aws-api client uses an http-client to send requests to AWS,
 including any operations you invoke _and_ fetching the region and
 credentials when you're running in EC2 or ECS. By default, each
-aws-api client creates its own http-client, which, in turn, manages
-its own resources. Invoke `cognitect.aws.client.api/stop` on the
-client if you want it to shut down any resources it and its
-http-client are using.
-
-If you're creating multiple aws-api clients, you can, optionally,
-create a single http-client and share it across aws-api clients e.g.
-
-``` clojure
-(require '[cognitect.aws.client.api :as aws])
-(def http-client (aws/default-http-client))
-(def s3-client (aws/client {:api :s3 :http-client http-client}))
-(def ssm-client (aws/client {:api :ssm :http-client http-client}))
-;; etc
-```
-
-If you call `stop` on `s3-client` or `ssm-client` in this example, the
-single http-client gets shut down for both.
+aws-api client uses a single, shared http-client, whose resources
+are managed by aws-api.
 
 ## Contributing
 
@@ -246,6 +235,27 @@ aws-api is incorporated into products and client projects, we prefer
 to do development internally and are not accepting pull requests or
 patches.
 
+## Contributors
+
+`aws-api` was extracted from an internal project at Cognitect, and
+some contributors are missing from the commit log.  Here are all the
+folks from Cognitect who either committed code directly, or
+contributed significantly to research and design:
+
+[Timothy Baldridge](https://github.com/halgari)<br/>
+[David Chelimsky](https://github.com/dchelimsky)<br/>
+[Benoît Fleury](https://github.com/benfle)<br/>
+[Fogus](https://github.com/fogus)<br/>
+[Stuart Halloway](https://github.com/stuarthalloway)<br/>
+[Rich Hickey](https://github.com/richhickey)<br/>
+[George Kierstein](https://github.com/MissInterpret)<br/>
+[Carin Meier](https://github.com/gigasquid)<br/>
+[Alex Miller](https://github.com/puredanger)<br/>
+[Michael Nygard](https://github.com/mtnygard)<br/>
+[Ghadi Shayban](https://github.com/ghadishayban)<br/>
+[Joseph Smith](https://github.com/solussd)<br/>
+[Marshall Thompson](https://github.com/Glassonion)
+
 ## Troubleshooting
 
 ### General
@@ -276,6 +286,17 @@ access.
 Remedy: check [AWS Regions and Endpoints](https://docs.aws.amazon.com/general/latest/gr/rande.html),
 and supply the correct endpoint as described in [nodename nor servname provided, or not known](#nodename-nor-servname-provided-or-not-known), above.
 
+#### Ops limit reached
+
+The underlying http-client has a `:pending-ops-limit` configuration
+which, when reached, results in an exception with the message "Ops
+limit reached". As of this writing, aws-api does not provide access to
+the http-client's configuration. Programs that encounter "Ops limit
+reached" can avoid it by creating separate http-clients for each
+aws-client. You may wish to explicitly stop
+(`com.cognitect.aws.api/stop`) these aws-clients when the are not
+longer in use to conserve resources.
+
 ### S3 Issues
 
 #### "Invalid 'Location' header: null"

UPGRADE.md

@@ -0,0 +1,48 @@
+# Upgrade Notes
+
+## 0.8.430
+
+This release changed the behavior of the following functions:
+
+### com.cognitect.aws.api/client
+
+As of 0.8.430, each aws-api client uses a single shared http-client by
+default.  Before this release, each aws-client got its own instance of
+http-client by default, which caused the number of threads consumed to
+increase linearly in relation to the number of aws-clients created.
+To reduce resource consumption in the case of many aws-clients, we
+recommended that you create a single instance of the http-client and
+explicitly share it across all aws-clients. This is no longer
+necessary.
+
+### com.cognitect.aws.api/stop
+
+With the introduction of a shared http-client, this function was
+updated so that it has no effect when using the shared http-client,
+but will continue to call `cognitect.aws.http/stop` on any other
+http-client instance.
+
+### effects
+
+These changes have the following effects:
+
+Programs that were creating multiple aws-clients without supplying
+an http-client, and without ever calling stop, will see a reduction
+in resource consumption.
+
+Programs that were creating an instance of
+`cognitect.aws.client.api/default-http-client` and sharing it across
+aws-clients should see no change. You can, however, safely stop doing
+that.
+
+For programs that were using the default aws-client constructor and
+calling stop on each aws-client, the shared http-client will not be
+shut down. This should have no negative impact on resource consumption,
+as there is only one http-client in this case, and its resources are
+managed by aws-api.
+
+For programs that were creating multiple aws-clients in order to get
+around an ["Ops limit reached"
+error](https://github.com/cognitect-labs/aws-api/issues/98), this is a
+breaking change. For this case, we recommend, for now, that you supply
+a new http-client for each aws-client.

build/doc

@@ -4,7 +4,7 @@ set -e
 
 echo "Building docs...\n"
 rm -rf ./target/autodoc
-mvn clojure:autodoc
+mvn -Pautodoc clojure:autodoc
 
 echo -e "Checking out gh-pages branch\n"
 rm -rf gh-pages

build/release

@@ -5,6 +5,15 @@ set -e
 echo "Cleaning..."
 rm -rf ./target
 
+echo "Aligning pom.xml with deps.edn ..."
+clj -Srepro -Spom
+if [ "$(git diff pom.xml)" = "" ]; then
+    echo "nothing to change"
+else
+    git add pom.xml
+    git commit -m "Update deps in pom.xml"
+fi
+
 echo "Calculating version..."
 prefix=`cat VERSION_PREFIX`
 suffix=`build/revision`
@@ -23,7 +32,7 @@ git tag -a v${version} -m "Release ${version}"
 git push origin v${version}
 
 echo "Updating README.md, CHANGES.md, and latest-releases.edn with ${version}"
-clj -A:update-versions
+clj -A:update-versions --update-latest-releases --update-changelog --update-readme
 git commit -m "Update README.md, CHANGES.md, and latest-releases.edn with ${version}" \
     README.md CHANGES.md latest-releases.edn
 git push