Open
Conversation
…ll need to sort by this wger-project#805
Dieterbe
reviewed
Jun 4, 2025
| diaryEntries.ingredientId == log.ingredientId && | ||
| diaryEntries.amount == log.amount && | ||
| diaryEntries.datetime.isAfter(DateTime.now().add(recentWindow))) | ||
| .length; |
Contributor
There was a problem hiding this comment.
hmm we do (diaryEntries.length)^2 iterations here. could be a performance issue. i have a lot of diary entries.
perhaps we could iterate once and update a map of ingredientId->count records.
not sure what's the best way to compare the performance though, does dart come with benchmark tools?
Dieterbe
reviewed
Jun 4, 2025
| @@ -226,15 +227,25 @@ class NutritionalPlan { | |||
| /// returns diary entries | |||
| /// deduped by the combination of amount and ingredient ID | |||
| List<Log> get dedupDiaryEntries { | |||
Contributor
There was a problem hiding this comment.
this function should be renamed to describe its actual usage.
like maybe "ingredientSuggestions" or something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add frequency of logged ingredients + Sort by descending
Related Issue(s)
Closes #805