fix: correct POSITIVE_CHECKS logic in seo-audit and 429 retry exhaustion in fetchWithRetry#41
Merged
MAlshaik merged 2 commits intowespreadjam:mainfrom Feb 28, 2026
Merged
Conversation
…ion in fetchWithRetry
- seo-audit: both branches of the POSITIVE_CHECKS if/else were
assigning `checkData.passed` identically, making the distinction
a no-op. Normal checks now correctly invert with `!checkData.passed`
so that a DataForSEO "passed=true" (problem absent) maps to isPassed=true.
- fetchWithRetry: a 429 on the final retry attempt fell through the
if-block and returned the rate-limit Response to the caller instead
of throwing. Now throws FetchRetryError("Rate limit exceeded after N
attempts") consistent with how 5xx exhaustion is handled.
- Add utils/resolve-path.ts as canonical path resolver - Supports dot notation, keyed array (contacts[0]), standalone index ([0].name), and empty paths - map.ts now imports from shared utility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seo-audit: both branches of the POSITIVE_CHECKS if/else were
assigning
checkData.passedidentically, making the distinctiona no-op. Normal checks now correctly invert with
!checkData.passedso that a DataForSEO "passed=true" (problem absent) maps to isPassed=true.
fetchWithRetry: a 429 on the final retry attempt fell through the
if-block and returned the rate-limit Response to the caller instead
of throwing. Now throws FetchRetryError("Rate limit exceeded after N
attempts") consistent with how 5xx exhaustion is handled.