fix(storybook): update color import after Figma token pipeline removal#26
Closed
vianmora wants to merge 2 commits into
Closed
fix(storybook): update color import after Figma token pipeline removal#26vianmora wants to merge 2 commits into
vianmora wants to merge 2 commits into
Conversation
serve-built-remix.ts expected the Vercel preset build format (build/server/<hash>/index.js). Since vite.config.ts skips vercelPreset() for non-Vercel builds, the output is now build/server/index.js directly, with build/server/assets/ as a subdirectory — causing the script to try to import assets/index.js (ERR_MODULE_NOT_FOUND). Check for index.js at the root of build/server/ first; fall back to the hash-subdirectory format for Vercel preset builds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Upstream removed the Figma token sync pipeline (db78ae4), deleting packages/design-system/src/__generated__/figma-design-tokens. The same color values are exported directly from design-tokens.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream commit
db78ae4dcremoved the Figma token sync pipeline, deletingpackages/design-system/src/__generated__/figma-design-tokens. Chromatic was failing because.storybook/preview.tsxstill importedcolorfrom that deleted file.Fix
Update the import to point to
design-tokens.tswhere the samecolorexport already exists.Test plan