fix(e2e): support standard Vite build output in serve-built-remix#25
Merged
Conversation
serve-built-remix.ts expected the Vercel preset build format (build/server/<hash>/index.js). Since vite.config.ts skips vercelPreset() for non-Vercel builds, the output is now build/server/index.js directly, with build/server/assets/ as a subdirectory — causing the script to try to import assets/index.js (ERR_MODULE_NOT_FOUND). Check for index.js at the root of build/server/ first; fall back to the hash-subdirectory format for Vercel preset builds. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
builder-e2eCI fails on all PRs based ondevelopsincevite.config.tswas updated to skipvercelPreset()for non-Vercel builds (commit222769e06).serve-built-remix.tsexpected the Vercel preset build format:Without
vercelPreset(), Vite produces the standard Remix output:The script found
assets/as the first subdirectory and tried to importassets/index.js→ERR_MODULE_NOT_FOUND.Fix
Check for
build/server/index.jsdirectly first (standard Vite format); fall back to the hash-subdirectory scan for Vercel preset builds.Test plan
builder-e2ejob passes on this PR