fix(ci): meeting reminder#110
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the GitHub Actions automation around TSC meeting notifications by removing the standalone “issue opened” Discord reminder workflow and instead sending a Discord notification directly from the meeting agenda generation workflow when a new meeting issue is created.
Changes:
- Remove the dedicated
.github/workflows/meeting-reminder.ymlworkflow. - Add an
idto thepkgjs/meet@v1step and a new “Notify Discord” step that looks up the created issue and posts it to Discord.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/meeting-reminder.yml |
Deletes the separate workflow that posted to Discord on issue creation. |
.github/workflows/generate-meeting-agendas.yml |
Adds step output wiring and a Discord notification step after agenda issue creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Do we need the workflow for this in the same yaml or can we have an unique one for this? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
It can be separate, but it would be slower (since github would need to spin up a new runner) |
|
perf not a problem in this repo and workflow |
|
I am fine to have this in the same workflow |
GitHub actions doesn't trigger for actions-generated issues, so this is the alternative way to send a reminder.
cc @evenstensberg