Skip to content

fix(ci): meeting reminder#110

Merged
alexander-akait merged 3 commits intowebpack:mainfrom
avivkeller:meeting-reminder
Mar 23, 2026
Merged

fix(ci): meeting reminder#110
alexander-akait merged 3 commits intowebpack:mainfrom
avivkeller:meeting-reminder

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Mar 23, 2026

GitHub actions doesn't trigger for actions-generated issues, so this is the alternative way to send a reminder.

cc @evenstensberg

Copilot AI review requested due to automatic review settings March 23, 2026 22:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the GitHub Actions automation around TSC meeting notifications by removing the standalone “issue opened” Discord reminder workflow and instead sending a Discord notification directly from the meeting agenda generation workflow when a new meeting issue is created.

Changes:

  • Remove the dedicated .github/workflows/meeting-reminder.yml workflow.
  • Add an id to the pkgjs/meet@v1 step and a new “Notify Discord” step that looks up the created issue and posts it to Discord.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/meeting-reminder.yml Deletes the separate workflow that posted to Discord on issue creation.
.github/workflows/generate-meeting-agendas.yml Adds step output wiring and a Discord notification step after agenda issue creation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@evenstensberg
Copy link
Copy Markdown
Member

Do we need the workflow for this in the same yaml or can we have an unique one for this?

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@avivkeller
Copy link
Copy Markdown
Member Author

It can be separate, but it would be slower (since github would need to spin up a new runner)

@evenstensberg
Copy link
Copy Markdown
Member

perf not a problem in this repo and workflow

@alexander-akait
Copy link
Copy Markdown
Member

I am fine to have this in the same workflow

@alexander-akait alexander-akait merged commit b55971a into webpack:main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants