Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6385 commits
Select commit Hold shift + click to select a range
1821c30
fix spec
Nov 20, 2014
8c6e227
Remove old file.
Nov 20, 2014
c8399e7
Moving the default options[:lock] configuration into find_order_by_to…
metade Nov 18, 2014
7f6bded
Prevent admins from editing return items that have a processed exchange
richardnuno Aug 19, 2014
7774746
Added reimbursed scope.
richardnuno Aug 20, 2014
dd54489
Update default same product rule
Aug 19, 2014
04f9978
fix api orders_controller_spec
jordan-brough Oct 22, 2014
f95116f
Bump version.
Nov 20, 2014
d73c9c8
Bump beta.
Nov 20, 2014
d316422
Make ruby 2.0 syntax higher priority.
Nov 21, 2014
5a4d1a7
[API] add stores to the REST API
peterberkenbosch Nov 18, 2014
2c65417
Update getting started guide.
Nov 21, 2014
9af575a
Fix for Promotion::Rules::Product
jordan-brough Nov 21, 2014
0d46a42
Round down on original payment and credit reimbursement types.
Oct 28, 2014
31a620a
Fix for ReimbursementTypeValidator
Oct 30, 2014
1f1b86c
Fix installer.rb release mistake on my part. Fixes #5662
Nov 21, 2014
ed86c05
bump version
Nov 21, 2014
0b12161
Next beta.
Nov 22, 2014
690dc86
Fix spree_auth_devise version for 2-4-stable
jordan-brough Nov 24, 2014
8d7882a
Fix translation keys.
Nov 24, 2014
92661aa
Only want latest valid payment. Fixes #5665
Nov 24, 2014
2199541
Update sandbox.sh to correct spree_auth_devise gem
deodad Nov 23, 2014
266a988
Merge pull request #5671 from jordan-brough/fix-spree-auth-devise-dep…
peterberkenbosch Nov 24, 2014
5efb1b5
Scope option value uniqueness to type. refs #5630
Nov 25, 2014
b6df8fa
Improve readability in FlexiRate calculator labels
dougjohnston Nov 20, 2014
c7369f4
Update edit.html.erb
arpanlepcha Nov 26, 2014
c882517
Update promotion rules guide
alepore Nov 26, 2014
0a59d45
Added gif to valid icon types
richardhartme Nov 26, 2014
0c427d6
Fix credit card related specs to work beyond 2014.
Dec 1, 2014
a854901
Adds option parameter to line_items api controller
Nov 21, 2014
ff9cedb
Fix vendor gitignore.
Dec 1, 2014
479ea21
Fix version number in application creation command
rajington Dec 2, 2014
f8381ae
Update _order_details.html.erb
ecerta Dec 1, 2014
8f767b4
Fixes ambigous stock_item_or_create method to accept either argument.…
Dec 1, 2014
d9644b7
Add deprecation warning.
Dec 3, 2014
e2773e8
Fix security issue when updating order by API.
leandro-gomez Dec 4, 2014
d07389e
Bump version
Dec 5, 2014
ae4c77a
Bump to beta.
Dec 5, 2014
d3013fe
Spree 2.4 upgrade guides state that Rails 4.1.6 is the minimal versio…
tomash Dec 4, 2014
0e52912
Better gateway error handling during refund creation
Dec 4, 2014
9265912
Use the shipping calculators in the test factories +
MattFenelon Dec 1, 2014
15f36b4
Prevent ordering unpersisted product properties. Fixes #5703
Dec 9, 2014
d2bb1bf
Stock Items n+1 update.
BenMorganIO Dec 5, 2014
bd31bb2
Fix grammar of error message. Fixes #5735
Dec 9, 2014
780a7ed
add missing translation editing_country
BenMorganIO Dec 9, 2014
a7b3874
Eager load associations in InventoryUnitBuilder
huoxito Dec 10, 2014
442b9f8
allow no variant products to be eligilbe in the exchange for
deodad Dec 10, 2014
4475563
Remove outdated deployment tip.
Dec 15, 2014
897cff2
Fix N+1 on Shipment#to_package call to variant from Differentiator
mtomov Dec 14, 2014
eadf761
Relaxing acts_as_list dependency.
pat Dec 15, 2014
d085dd1
Make same product eligible variants DRY.
Dec 16, 2014
920a56b
Remove unused styles. Fixes #5797
Dec 18, 2014
9444d1e
Eagerly load product images and prices using preload.
jschwertfeger Dec 18, 2014
d1f9a40
Fix cc factory.
Dec 18, 2014
18ba0ef
Revert recommendation to use modules for extensions.
jordan-brough Dec 18, 2014
9f0d4b4
Lockdown monetize to fix specs for now.
Dec 23, 2014
193091a
Update ruble symbol.
Dec 23, 2014
4146d7f
Require latest monetize.
Dec 23, 2014
50e5861
Enable/disable every input (input, textarea, select, etc.) in payment…
Dec 19, 2014
a12050b
Use order’s completed_at to determine time since purchase
richardnuno Dec 22, 2014
114eac3
Only consider eligible promos for used_by?
Dec 18, 2014
b018b43
fix http/https fonts links
alepore Dec 19, 2014
4121992
Update payment_total on void.
Dec 23, 2014
c33b1c0
Show error message when adding items to order in admin fails
Dec 22, 2014
080da35
Revert "Show error message when adding items to order in admin fails"
Dec 23, 2014
4da14fa
Fix payment sample card for 2015
jhawthorn Jan 2, 2015
56c681b
Do not trigger full order update when fulfilling a backordered order
ifan-godaddy Dec 30, 2014
5c05b46
Remove a duplication in api routes.
nguyentruongtho Dec 31, 2014
bc19fcb
Remove persist_invalid from order
Dec 24, 2014
834bd41
Guides - improve consistency of ruby markdown code
pawelnguyen Jan 5, 2015
2d93347
Address factory uses valid phone number.
Jan 6, 2015
d823048
returns options text for master product
Jan 5, 2015
0a62c58
Always initialize master variants as master, so proper validations ca…
sevenseacat Jan 7, 2015
4e9c527
Guides - add missing headers to Overview sections
pawelnguyen Jan 7, 2015
d52c7b6
Guides - fix toggling of Upgrade Guides together with Advanced Topics
pawelnguyen Jan 7, 2015
6ba1cfd
Fix included scope for Rails 4.1.9...
Jan 7, 2015
1bbdbfd
Fix included scope reference.
Jan 7, 2015
2f88c2d
Newer versions of acts_as_list changed default to 1.
Jan 8, 2015
54f00ea
Revert "Newer versions of acts_as_list changed default to 1."
Jan 8, 2015
1ace191
rename the IncompleteReimbursement to be extactly what it is.
peterberkenbosch Nov 18, 2014
0aa7b89
Allow overriding db/default/spree seed data.
Jan 9, 2015
64b87bf
Touch ancestors and taxonomoy on taxon create/update.
Jan 9, 2015
cf22b7d
Try touch.
Jan 9, 2015
2c26b5c
Guides - add explanation of order attributes
pawelnguyen Jan 12, 2015
5961c1e
fix duplicate user_id for last_incomplete_spree_order
lanrion Jan 12, 2015
f40ef67
Use try! instead.
Jan 13, 2015
f20b46c
Fix specs for rails 4.1.9.
Jan 13, 2015
bc47452
Fix authorization check. Fixes #5624
Jan 13, 2015
cd49a23
Fix spec by stubbing out unnessecary method.
Jan 9, 2015
53ec3c2
translate hardcoded strings on cc payment form
alepore Jan 14, 2015
6aa500c
Improve update_payment_state again
Jan 14, 2015
45bd609
Fix property name for auto_capture_on_dispatch.
MisinformedDNA Jan 20, 2015
1665eca
Add store association.
Jan 20, 2015
a4819f6
Fix Backend Cache-Clearing With Custom Mount Path
Jan 21, 2015
d80d122
Update asset initializers. Fixes #5923
Jan 22, 2015
817fd86
Add test to prove taxon updated up isn't touched
Jan 22, 2015
90406f8
Update package.rb missing order.currency
ilanaseid Jan 22, 2015
e3843c7
Orders should have a store.
Jan 22, 2015
ac63b55
Update store controller spec.
Jan 22, 2015
5ac903e
deprecate methods.
Jan 23, 2015
f577a3b
Add deprecation warning for OrderPopulator.
Jan 23, 2015
631e3d5
Improve checkout API errors.
Jan 23, 2015
ed60c1b
Fix spec setup.
Jan 23, 2015
d4bf4db
Fix calculating Order#payment_total for partial captures.
Jan 23, 2015
84ab989
Lockdown select2-rails to fix specs.
Jan 23, 2015
95267f9
JS fix for admin resource destroy success message
MattDunbar Jan 26, 2015
b45772d
Call set_list_position to fix persistence. Fixes #5947
Jan 26, 2015
fc1e939
Fix an incorrect inverse_of
Dec 10, 2014
c5fdda8
Revert "Fix calculating Order#payment_total for partial captures."
Jan 27, 2015
8167d8f
Replace Hub links with Wombat
Jan 27, 2015
930a410
Merge pull request #5956 from devilcoders/2-4-stable
peterberkenbosch Jan 27, 2015
dcd415d
Lockdown paranoia.
Jan 28, 2015
e55892c
Let $base-font-family be overridable
delphaber Jan 29, 2015
0ffe8dd
Mention gitter in getting help guide.
Jan 29, 2015
db748bf
Partial payment capturing splits remaining payment amount into new re…
Jan 26, 2015
33c6611
FreeShipping should reapply when code is entered. Fixes #5881
Jan 29, 2015
69f95b2
Use final_amount to include taxes.
Jan 29, 2015
de18870
Merge pull request #5975 from delphaber/patch-1
JDutil Jan 29, 2015
72d65d6
Adjustments upgrade migration should fail on save / destroy fail
MattDunbar Feb 1, 2015
b637c28
Adjustments upgrade migration efficiency improvement.
MattDunbar Jan 30, 2015
5569ba2
Fix payment total to calculate refunds. Fixes #5907
Feb 4, 2015
d7967de
Bump version.
Feb 4, 2015
d772b01
Bump beta.
Feb 4, 2015
26d4192
Guides: Mention that preferences are serialized in `Spree::Base`
vinnicc Feb 5, 2015
fd57547
default fallback url should be unique on update
Anirudh-Gupta Feb 5, 2015
52d4100
Cancelling return authorization cancels also all return items that ca…
pawelnguyen Jan 16, 2015
906b303
Only set other records to not default.
Feb 9, 2015
3179e6c
route not found when called from other namespace
arthurtalkgoal Feb 6, 2015
b4c5583
fix order population with out of stock variants
kennyadsl Feb 10, 2015
7b1ff5c
Deployment service no longer exists.
Feb 10, 2015
dbb11f0
Add Variant#descriptive_name method.
jozw Feb 2, 2015
82060b8
switch calls so that completed? predicate is called first
BenMorganIO Feb 18, 2015
152938f
Fix invalid scope in admin edit order template
Feb 18, 2015
11363ea
Fix link.
JDutil Feb 23, 2015
39494af
Included tax total should be included as well. Fixes #5926
Feb 23, 2015
6ba2dbc
Bump
Feb 23, 2015
5b9c8f5
BUmp beta.
Feb 23, 2015
fb45ad8
dockerfile for building guides with nano and serving with simple ngin…
rlister Feb 23, 2015
9a4cd59
Mention gotcha about payment method environment.
Feb 26, 2015
85f5308
Fix specs messed up in git conflict.
Feb 27, 2015
02c4e6f
Require token for any API endpoint & remove JSONP support.
huoxito Mar 2, 2015
5c9493d
Bump version.
Mar 3, 2015
e813b64
Bump version.
Mar 3, 2015
c829708
Updates the track_inventory JSON attribute on variant to respect Spre…
smartacus Feb 26, 2015
044675f
Remove JSONP support. Fixes #6105
Mar 4, 2015
99d1a89
add table name for Promotion.active scope
andreapavoni Mar 4, 2015
828e23e
OptionType.acts_as_list fixes #6114
Mar 5, 2015
2c6b8da
Need to include token to get taxons after 2.4.5
rharriso Mar 5, 2015
7d737a1
Add token to api calls. Fixes #6122
Mar 6, 2015
bb06fca
Taxonomies act_as_list. Fixes #6037
Feb 16, 2015
c928bad
Fixed a bug in payments js at backend
Mar 6, 2015
5f8142d
Correct reflect the payment total and state after a refund.
bryanmtl Mar 8, 2015
69507ce
Bump version.
Mar 10, 2015
c126f4e
Bump to beta.
Mar 10, 2015
3a52596
Fix track_inventory on big variant rabl template.
smartacus Mar 10, 2015
6759ebf
Fix variant sorting
dougjohnston Mar 11, 2015
4ed9be1
Product properties act as list. Fixes #6157
Mar 12, 2015
1bfd25a
Fix span tag not closed in products partial
rbngzlv Mar 13, 2015
e3c5f99
Fixing issue where only incomplete orders where displayed when not ch…
frankmt Mar 13, 2015
7097ccc
Add missing api key in product picker.
frahugo Mar 16, 2015
60307cd
Only allow Spree::Order filtering for ordered Variants.
parndt Mar 15, 2015
507ef9e
Need to permit an array for option_value_ids
huoxito Mar 17, 2015
1165ed2
Need to permit an array for option_type_ids
huoxito Mar 17, 2015
decd670
Use built in leaf? method for detecting no children.
parndt Mar 17, 2015
8a90ef2
Optimize Promotion#eligible_rules.
Mar 17, 2015
c451484
Include api key for taxon reordering.
Mar 18, 2015
6811944
We need to lock down to 4.1.9 until refs #6213 is fixed.
Mar 23, 2015
19307ae
Variant price_modifier_amount should find method using option key not…
smartacus Mar 20, 2015
4fee2ee
Remove index.html from backend's js assets directory to avoid unneces…
Mar 27, 2015
874faf2
Fixes outstanding balance when order has reimbursements. refs #6229
Apr 1, 2015
e4e4627
Use all_adjustments to access order promotion because it could be at …
ifan-godaddy Mar 30, 2015
f8f760c
Update old migration with i18n workaround
alepore Apr 4, 2015
1a6df8a
Fix broken rspec (float -> string conversion may be truncated for cer…
ifan-godaddy Apr 17, 2015
d30847a
update spree model calls to namespaced references
williscool Apr 16, 2015
79f7e24
Avoid recursion on the create_line_items promotion action
manmartinez Apr 17, 2015
6496dcf
Replace newlines with spaces in line-item description
berkes Apr 19, 2015
856cf78
Touch product when taxon assigned. Fixes #6320
Apr 22, 2015
b5ff545
Validate stock location presence. Fixes #5960
Apr 27, 2015
9f817f6
Bump version.
May 5, 2015
05c1c23
Bump beta.
May 5, 2015
f4779b1
remove unnecessary payments script
greinacker May 6, 2015
13f1df5
fix final_price_with_items to calculate correct shipment amount as pe…
kunalchaudhari May 9, 2015
4e4f2a7
Fix bug where line item quantity cannot be set to zero for out-of-sto…
dkubb Jun 18, 2014
21348ba
Fix state_changes to be destroyed when the associated order is destroyed
dkubb Nov 13, 2014
004e9c3
Remove unused method from Spree::OrderUpdater
dkubb Nov 18, 2014
8906b23
Change before_filter to before_action.
dkubb Nov 7, 2014
8e589bd
Add validations to stock items and stock movements.
dkubb Mar 31, 2014
e491002
Only perform Order#reload when needed
mbj Sep 25, 2014
ffff8b5
fix adjustment calculation in #item_cost which in incorrectly calcula…
kunalchaudhari May 13, 2015
56c6cfc
Add acts_as_list scope to Spree::Variant
Domenoth May 13, 2015
c310002
Merge pull request #6385 from Domenoth/2-4-stable
JDutil May 13, 2015
1dd43f2
Add Spree::Payment#editable?
dkubb Nov 5, 2014
b5381b7
Modify punch_slug to ensure total slug length does not surpass maximu…
Apr 2, 2015
8001fe0
Promote Order#all_adjustments to association.
mbj Sep 24, 2014
8f7905c
Merge pull request #6425 from ddomingues/modify-punch_slug
JDutil May 27, 2015
7f9150c
Revert "Promote Order#all_adjustments to association."
May 27, 2015
4f4bd52
Fix performance of cart promotion handler select.
mbj Dec 10, 2014
01fd680
set_position conflicts with acts_as_list
parndt May 29, 2015
3367a05
Update to paranoia 2.1.x
jhawthorn Jan 28, 2015
ccb500a
Fixes the destruction cascade of slugs history
ddomingues May 25, 2015
d564a94
Promote Order#all_adjustments to association.
mbj Sep 24, 2014
bf22d8b
Add GA user id tracking.
paultyng Jun 1, 2015
25542a3
Require rma for each customer return. Fixes #5982
Jun 12, 2015
46ceeec
Fix specs from change in a44f939a79e1147c18c1aad2981c83dda3122243
Jun 12, 2015
c0089b1
Remove method added in git conflict.
Jun 13, 2015
aa554d6
Bump Rails.
Jun 16, 2015
406ab42
Delete order merge to Spree::OrderMerge
Jun 16, 2015
793f88a
Only run detect on eligable line items.
Jun 23, 2015
c6e1246
Reject params[:q][:deleted_at_null] instead of deleting it to sustain…
Jun 30, 2015
d51a45c
Added promotions to product page cache key
Jul 1, 2015
ca315b5
Added a spec for checking the payment state after an order has been c…
alexstoick Jun 30, 2015
b7a54df
Must handle payment processing cancel response to void transaction. F…
Jul 6, 2015
651f537
Add acts_as_paranoid to calculators. Fixes #5858
Jul 7, 2015
72a3c7a
Remove new reimbursement type button
Jul 7, 2015
aed7dc4
Merge pull request #6583 from yf6/2-4-stable-remove-button
JDutil Jul 10, 2015
8730f09
Don't allow api users to specify template.
Jul 20, 2015
ee9491a
Require payments to have valid payment method
charlie-hadden Jul 20, 2015
2ae6d31
Bump version.
Jul 20, 2015
fb24735
Bump to beta.
Jul 20, 2015
e16c483
use all_adjustments when for shipment adjustment
wuboy0307 Jul 23, 2015
203657e
Destroy shipments when verifying available rates
eric1234 Jul 14, 2015
a0cc275
Don't render arbitrary RABL templates
Jul 24, 2015
39a90a1
Bump version.
Jul 28, 2015
a67d425
Bump to beta.
Jul 28, 2015
c225ea6
Merge pull request #6645 from magiclabs/fix-reimbursement-rounding
JDutil Jul 31, 2015
2f17e57
Default to false as we're removing alerts.
JDutil Aug 12, 2015
92c52f7
Stop sending response code through the api
Aug 17, 2015
7fa13cb
Whitelist which attributes are allowed to be queried via ransack
Aug 17, 2015
9b2c217
Whitelist considered risky.
Aug 19, 2015
82067e5
Bump version.
Aug 19, 2015
333bbc6
Bump beta.
Aug 19, 2015
38299a5
Fix update! returning nil when !source.present.
Aug 22, 2015
1a46f9c
Add regression test
Aug 24, 2015
2fb613f
Merge pull request #6689 from archSeer/adjustment-update-fix
JDutil Aug 24, 2015
0621298
Add name and description to product whitelist.
Aug 27, 2015
ef635b9
Fix spec to use a non ransackable attribute.
Aug 27, 2015
d9bd194
Remove Spree::Alert.
Jun 20, 2015
5388e98
Add failing classification test specs
lsirivong Sep 19, 2015
5f59143
Use before_remove to maintain classifications' positions integrity
lsirivong Sep 19, 2015
9d0786a
Appease houndci
lsirivong Sep 19, 2015
d7b7224
Merge pull request #6744 from lsirivong/feature/maintain-classificati…
JDutil Sep 21, 2015
4b5d3a7
Upon deleting a State/Country, also delete it from the Zones.
Sep 25, 2015
c5c8be0
Merge pull request #6763 from archSeer/fix-dependent-zone-members
JDutil Sep 25, 2015
6fa2058
Add correct scope for quantity not available translation
davidwinter Oct 13, 2015
dfd548b
Merge pull request #6830 from davidwinter/patch-1
JDutil Oct 14, 2015
59800a6
Add missing translation to en.yml
sowasred2012 Nov 23, 2015
17eb7d3
Remove rogue `<td>` tag
sowasred2012 Nov 24, 2015
676d328
Merge pull request #6889 from sowasred2012/patch-2
damianlegawiec Jan 21, 2016
17e827a
Merge pull request #6886 from sowasred2012/patch-1
damianlegawiec Jan 21, 2016
28ed0bb
update activmerchant version
Apr 15, 2015
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
22 changes: 22 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# http://EditorConfig.org
# https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties

root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 2
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
tab_width = 2

[**.rb]
max_line_length = 80

[**.js, **.coffee]
max_line_length = 120

[*.md]
trim_trailing_whitespace = false
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
.idea
.loadpath
.project
.ruby-version
bin/*
public/dispatch.cgi
public/dispatch.fcgi
Expand Down Expand Up @@ -37,19 +38,18 @@ spree_test
testapp
**/spec/dummy
tmp
vendor/rails
vendor/extensions/google_base
public/google_base.xml
public/template_google_base.xml
coverage/*
var
TAGS
nbproject
vendor/extensions/theme_default/app/stylesheets/*.css
./vendor
tags
*.swp
rerun.txt
test_app
.rvmrc
**/coverage
*/.sass-cache
.localeapp
19 changes: 19 additions & 0 deletions .teatro.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
stage:
before:
- export SECRET_KEY_BASE=abc
- bundle exec rake sandbox
- echo 'Rails.logger = Logger.new(STDOUT)' > sandbox/config/initializers/logger_stdout.rb
- cd sandbox
- ln -sf $PWD/public $PWD/../public

run:
# workdir is sandbox
- bundle exec rails server

database:
- echo "skip database stage. rake sandbox already did everything"

config:
database: postgresql
services:
- postgresql
41 changes: 17 additions & 24 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,29 +1,22 @@
before_script:
- 'sh -e /etc/init.d/xvfb start'
- 'export DISPLAY=:99.0'
- sh -e /etc/init.d/xvfb start
- export DISPLAY=:99.0
bundler_args: --without development production --quiet
env:
- GEM='api:sqlite'
- GEM='api:mysql'
- GEM='api:postgres'
- GEM='core:sqlite'
- GEM='core:mysql'
- GEM='core:postgres'
- GEM='dash:sqlite'
- GEM='dash:mysql'
- GEM='dash:postgres'
- GEM='promo:sqlite'
- GEM='promo:mysql'
- GEM='promo:postgres'
- GEM=api DB=mysql
- GEM=api DB=postgres
- GEM=backend DB=mysql
- GEM=backend DB=postgres
- GEM=core DB=mysql
- GEM=core DB=postgres
- GEM=frontend DB=mysql
- GEM=frontend DB=postgres
- GEM=sample DB=mysql
- GEM=sample DB=postgres
before_install:
- cd $GEM; export BUNDLE_GEMFILE="`pwd`/Gemfile"
script:
- 'ci/travis.sh'
notifications:
email:
- ryan@spreecommerce.com
irc:
use_notice: true
skip_join: true
channels:
- "irc.freenode.org#spree"
- bundle exec rake test_app
- RSPEC_RETRY_COUNT=2 bundle exec rake spec
rvm:
- 1.9.3
- 2.1.5
43 changes: 28 additions & 15 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,30 @@
Spree is an open source project and we encourage contributions. Please see the [contributors guidelines](http://spreecommerce.com/documentation/contributing_to_spree.html) before contributing.
Spree is an open source project and we encourage contributions. Please see the
[contributors guidelines](http://spreecommerce.com/documentation/contributing_to_spree.html)
before contributing.

## Filing an issue

When filing an issue on the Spree project, please provide these details:

* A comprehensive list of steps to reproduce the issue.
* The version of Spree *and* the version of Rails.
* A list of all extensions.
* What you're *expecting* to happen compared with what's *actually* happening.
* Your application's complete `Gemfile.lock`, and `Gemfile.lock` as text in a [Gist](https://gist.github.com) (*not as an image*)
* Any relevant stack traces ("Full trace" preferred)

In 99% of cases, this information is enough to determine the cause and solution to the problem that is being described.
In 99% of cases, this information is enough to determine the cause and solution
to the problem that is being described.

Any issue that is open for 14 days without actionable information or activity will be marked as "stalled" and then closed. Stalled issues can be re-opened if the information requested is provided.
Please remember to format code using triple backticks (\`) so that it is neatly
formatted when the issue is posted.

Any issue that is open for 14 days without actionable information or activity
will be marked as "stalled" and then closed. Stalled issues can be re-opened if
the information requested is provided.

## Pull requests

We gladly accept pull requests to fix bugs and, in some circumstances, add new features to Spree.
We gladly accept pull requests to add documentation, fix bugs and, in some circumstances,
add new features to Spree.

Here's a quick guide:

Expand All @@ -24,17 +33,18 @@ Here's a quick guide:
2. Run the tests. We only take pull requests with passing tests, and it's great
to know that you have a clean slate:

$ bundle install
$ bundle exec rake test_app
$ bundle exec rake
$ bash build.sh

3. Add a test for your change. Only refactoring and documentation changes
require no new tests. If you are adding functionality or fixing a bug, we need
a test!
3. Create new branch then make changes and add tests for your changes. Only
refactoring and documentation changes require no new tests. If you are adding
functionality or fixing a bug, we need tests!

4. Make the test pass.
4. Push to your fork and submit a pull request. If the changes will apply cleanly
to the latest stable branches and master branch, you will only need to submit one
pull request.

5. Push to your fork and submit a pull request. If the changes will apply cleanly to the latest stable branches and master branch, you will only need to submit one pull request.
5. If a PR does not apply cleanly to one of its targeted branches, then a separate
PR should be created that does. For instance, if a PR applied to master & 2-1-stable but not 2-0-stable, then there should be one PR for master & 2-1-stable and another, separate PR for 2-0-stable.

At this point you're waiting on us. We like to at least comment on, if not
accept, pull requests within three business days (and, typically, one business
Expand All @@ -53,9 +63,12 @@ Syntax:
* Two spaces, no tabs.
* No trailing whitespace. Blank lines should not have any space.
* Prefer &&/|| over and/or.
* `MyClass.my_method(my_arg)` not `my_method( my_arg )` or my_method my_arg.
* `MyClass.my_method(my_arg)` not `my_method( my_arg )` or `my_method my_arg`.
* `a = b` and not `a=b`.
* `a_method { |block| ... }` and not `a_method { | block | ... }`
* Follow the conventions you see used in the source already.
* -> symbol over lambda
* Ruby 1.9 hash syntax `{ key: value }` over Ruby 1.8 hash syntax `{ :key => value }`
* Alphabetize the class methods to keep them organized

And in case we didn't emphasize it enough: we love tests!
Loading