fix(ci): align Redis config and remove risky npm upgrade step#56
Open
circleci-app[bot] wants to merge 5 commits into
Open
fix(ci): align Redis config and remove risky npm upgrade step#56circleci-app[bot] wants to merge 5 commits into
circleci-app[bot] wants to merge 5 commits into
Conversation
- Remove --requirepass from Redis sidecar: .env.ci has AAA_REDIS_PASSWORD commented out, so the client connects without auth; requiring a password caused every test run to fail with an authentication error after checkout. - Remove `sudo npm install -g npm@latest`: upgrading npm globally is slow, can introduce breaking changes, and is not needed since cimg/node:22.7 ships a recent npm already. - Add HUSKY=0 env var to the install step so husky hooks are skipped in CI. AI-Generated: true
Remove Redis save option from CircleCI config.
Updated Redis image version and modified command.
Updated Redis image to use 'redis:latest' and added environment variable for memory overcommit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--requirepassfrom Redis sidecar:.env.cihasAAA_REDIS_PASSWORDcommented out, meaning the app connects to Redis without authentication. The sidecar was requiring passwordeYVX7EwVmmxKPCDmwMtyKVge8oLd2t81, causing every test run to fail with a Redis auth error after checkout succeeded.sudo npm install -g npm@latest: upgrading npm globally on each CI run is slow (~30s+), can introduce breaking changes from upstream, and is unnecessary sincecimg/node:22.7already ships a recent npm.HUSKY: "0"to the install step: prevents husky from installing git hooks duringnpm installin CI where they serve no purpose.Root cause of workflow 7b7073bf failure
Job 142 (
test-source) failed at thecheckoutstep due to a transient blobless clone hang. The structural Redis password mismatch means the workflow would have continued to fail at the test step on every subsequent run even after checkout succeeded.Test plan
test-sourcejob reaches the "Run Tests" step without errorsNOAUTH Authentication requirederrors in test output)npm installcompletes without husky-related failureshttps://app.circleci.com/agents/gh/web2solutions/chat/0acfd8d1-0d00-4b57-bcb1-51419a4e0b00