Fixes #1326 - remove unused font awesome library#1327
Draft
trubach wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1326
Summary
Removes the bundled Font Awesome 4.7.0 library and the dead
illinois-icons.cssstylesheet from the theme. Font Awesome was loaded site-wide via the global library but only used for 3 decorative arrow glyphs, and illinois-icons.css was never matched by any markup (icons render through the Toolkit<ilw-icon>web component). This removes ~43 unnecessary files and trims the CSS shipped on every page.Changes
•
illinois_framework_theme.libraries.yml— Removed bothfont-awesome.cssandillinois-icons.cssfrom the global library'scss.themesection.•
css/node/node.news.css&css/node/node.blog.css— Replaced the 3 Font Awesome arrow glyphs with plain Unicode characters (rendered in the system font, no icon font required) and removed the now-unneeded font-family: FontAwesome; declarations:• \f054 (chevron-right) → \203A ( › ) on .readmore::after — both files
• \f101 (angle-double-right) → \BB ( » ) on .hvrbox-title::after — news
• Deleted fonts/font-awesome-4.7.0/ — Removed the entire directory (43 files): Font Awesome CSS/min/map, webfonts + FontAwesome.otf , the Illinois-Icons-Line.* font files, illinois-icons.css , the less/ and scss/ source dirs, and HELP-US-OUT.txt .
• GEMINI.md — Updated to drop the Font Awesome references in the library description and External Dependencies sections.
What was intentionally kept
• The $icon_map array and cta_icon logic in illinois_framework_theme.theme — these translate stored icon keys into icon names and are unrelated to the removed CSS.
Testing / verification
• grep confirms zero remaining references to font-awesome , fontawesome , or illinois-icons across the theme, and no remaining \f054 / \f101 glyphs.
• Static review confirms no template/JS uses .fa / .fa-* or il-icon-* classes.
• Note: Run lando drush cr after merge/deploy to flush the library and CSS-aggregation registry. Spot-check that "read more" links show › , hover-box titles show » , and that CTA, icon-row, and footer icons still render.
Notes for reviewers / downstream
If any sub-theme or consumer references these stylesheets or the fonts/font-awesome-4.7.0/ path directly, it will need the same update.
✅ Peer Review Checklist
Reviewers: Please verify the following before approving.
t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)ksm(),dpm(),console.log) has been removed.📸 Screenshots / Video (Optional)
If this is a UI change, please attach a screenshot or a quick screen recording of the change in action.