Adjust the ils-component javascript in a local version of the library#1273
Closed
hpleas wants to merge 2 commits into
Closed
Adjust the ils-component javascript in a local version of the library#1273hpleas wants to merge 2 commits into
hpleas wants to merge 2 commits into
Conversation
Contributor
|
This was addressed in the component in the PR web-illinois/shared-components#32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
In this commit the ils-contentslider component library is pulled locally and adjusted with preferred attributes. Preferrable would be to reset the attributes in the ilfw-drupal code, if this will not be adjusted by component maintainers.
See attempt for override in js/paragraph-content-slider.js
✅ Peer Review Checklist
Reviewers: Please verify the following before approving.
t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)ksm(),dpm(),console.log) has been removed.📸 Screenshots / Video (Optional)
With Adjusted Library


Without Adjusted Library