Skip to content

Adjust the ils-component javascript in a local version of the library#1273

Closed
hpleas wants to merge 2 commits into
5.xfrom
hpleas/issue-1247-content-slider-paragraph-centered
Closed

Adjust the ils-component javascript in a local version of the library#1273
hpleas wants to merge 2 commits into
5.xfrom
hpleas/issue-1247-content-slider-paragraph-centered

Conversation

@hpleas

@hpleas hpleas commented May 7, 2026

Copy link
Copy Markdown
Contributor

📝 Description

In this commit the ils-contentslider component library is pulled locally and adjusted with preferred attributes. Preferrable would be to reset the attributes in the ilfw-drupal code, if this will not be adjusted by component maintainers.

See attempt for override in js/paragraph-content-slider.js


✅ Peer Review Checklist

Reviewers: Please verify the following before approving.

  • The pull request links to the issue it is addressing in the comment and in the "Development" section of the PR
  • There is a short summary that describes how the fix is implemented
  • Verifying work: Verify that the changes made are addressing the linked issue
  • Accessibility: Changes that might impact accessibility are reviewed to work with keyboard navigation and screen readers
  • Responsive: Layout is tested on desktop, tablet, and mobile screens
  • Config changes: Any configuration updates are tested and verified using the Distribution Update import
  • Security: Output is sanitized (using t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)
  • Cleanliness: All debug code (ksm(), dpm(), console.log) has been removed.
  • Comments: Complex logic is explained inline.
  • Documentation: Any relevant documentation has been updated (this can be a separate issue if needed)

📸 Screenshots / Video (Optional)

With Adjusted Library
Screenshot 2026-05-07 at 12 15 24 PM
Without Adjusted Library
Screenshot 2026-05-07 at 12 22 28 PM

@trubach

trubach commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This was addressed in the component in the PR web-illinois/shared-components#32

@trubach trubach closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content Slider paragraph items should be centered on the page when it's not spanning the width of the browser

2 participants