fix: parse asyncConfig from replication config GET response by jfrancoa · Pull Request #1996 · weaviate/weaviate-python-client

jfrancoa · 2026-03-26T13:43:45Z

Summary

The server returns asyncConfig inside replicationConfig on collection GET, but the Python client was silently dropping it — replication_config.async_config was always missing.
Add _AsyncReplicationConfig dataclass (14 optional int fields matching the server schema) and wire it into _collection_config_from_json.
Export AsyncReplicationConfig from weaviate.outputs.config so users can type-check against it.

Test plan

Unit test: parsing replication config without asyncConfig (backwards compat)
Unit test: parsing replication config with full asyncConfig
Unit test: parsing replication config with partial asyncConfig (missing fields → None)
Unit test: to_dict() round-trip includes asyncConfig when present
Unit test: to_dict() omits asyncConfig when None
Pre-commit hooks pass (ruff, pyright, stubs-autogen, docstrings)

🤖 Generated with Claude Code

The server returns asyncConfig inside replicationConfig on collection GET, but the Python client was not parsing it. Add _AsyncReplicationConfig dataclass, wire it into _collection_config_from_json, and export AsyncReplicationConfig from the public API surface. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

orca-security-eu

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Infrastructure as Code	0 0 0 0	View in Orca
Passed	SAST	0 0 0 0	View in Orca
Passed	Secrets	0 0 0 0	View in Orca
Passed	Vulnerabilities	0 0 0 0	View in Orca

test/collection/test_config.py

Existing callers construct _ReplicationConfig without async_config. Adding a default prevents a breaking positional argument error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Fixes the Python client’s parsing of collection replicationConfig so the server-provided asyncConfig is preserved (instead of being silently dropped), and exposes the parsed type for user type-checking.

Changes:

Add _AsyncReplicationConfig / AsyncReplicationConfig output dataclass and attach it to ReplicationConfig as async_config.
Parse replicationConfig.asyncConfig in _collection_config_from_json.
Add unit tests covering presence/absence/partial asyncConfig and to_dict() behavior; export AsyncReplicationConfig via weaviate.outputs.config.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`weaviate/outputs/config.py`	Re-exports `AsyncReplicationConfig` for public typing.
`weaviate/collections/classes/config_methods.py`	Parses `replicationConfig.asyncConfig` into `_AsyncReplicationConfig` during collection GET config parsing.
`weaviate/collections/classes/config.py`	Introduces the `_AsyncReplicationConfig` dataclass and adds `async_config` to `_ReplicationConfig`.
`test/collection/test_config.py`	Adds tests validating parsing and `to_dict()` serialization for `asyncConfig`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

weaviate/collections/classes/config_methods.py

weaviate/collections/classes/config.py

- Default async_config to None for backwards compatibility (copilot) - Use `is not None` instead of truthiness check for asyncConfig parsing so empty dict is not silently dropped (copilot) - Replace unit tests calling _collection_config_from_json with integration round-trip tests (dirkkul) - Add integration test for creating with async_config then removing it Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

integration/test_collection_config.py

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

weaviate/collections/classes/config_methods.py

Override merge_with_existing on _ReplicationConfigUpdate to: - Replace entire asyncConfig when provided (not merge), so omitted fields revert to server defaults. This follows the generative/reranker clear+replace pattern. - Pop asyncConfig from schema when asyncEnabled=False, so disabling async replication also clears the config. Add unit tests for all merge behaviors (replace, clear, preserve, reset) and integration tests for unsetting individual fields, resetting all fields via empty async_config(), and disabling async replication. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

weaviate/collections/classes/config.py

Revert to truthiness check when parsing asyncConfig from server response. An empty dict {} means no custom config and should be treated as absent (None), not as an _AsyncReplicationConfig with all None fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

codecov-commenter · 2026-03-27T06:41:54Z

Codecov Report

❌ Patch coverage is 97.26027% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.95%. Comparing base (ccf4f61) to head (53c9687).
⚠️ Report is 68 commits behind head on main.

Files with missing lines	Patch %	Lines
integration/test_collection_config.py	94.20%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
+ Coverage   87.84%   87.95%   +0.11%     
==========================================
  Files         280      280              
  Lines       21347    21652     +305     
==========================================
+ Hits        18752    19045     +293     
- Misses       2595     2607      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jfrancoa requested a review from Copilot March 26, 2026 13:43

orca-security-eu bot reviewed Mar 26, 2026

View reviewed changes

jfrancoa requested review from bevzzz and tsmith023 March 26, 2026 13:45

dirkkul reviewed Mar 26, 2026

View reviewed changes

test/collection/test_config.py Outdated Show resolved Hide resolved

test/collection/test_config.py Outdated Show resolved Hide resolved

test/collection/test_config.py Outdated Show resolved Hide resolved

fix: default async_config to None in _ReplicationConfig

d26429d

Existing callers construct _ReplicationConfig without async_config. Adding a default prevents a breaking positional argument error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI reviewed Mar 26, 2026

View reviewed changes

weaviate/collections/classes/config_methods.py Show resolved Hide resolved

weaviate/collections/classes/config.py Outdated Show resolved Hide resolved

jfrancoa requested a review from Copilot March 26, 2026 13:59

Copilot started reviewing on behalf of jfrancoa March 26, 2026 14:00 View session

dirkkul reviewed Mar 26, 2026

View reviewed changes

integration/test_collection_config.py Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 26, 2026

View reviewed changes

weaviate/collections/classes/config_methods.py Show resolved Hide resolved

jfrancoa force-pushed the jose/fix-async-repl-config-get branch 2 times, most recently from 4bff06b to e5ec450 Compare March 26, 2026 15:37

jfrancoa force-pushed the jose/fix-async-repl-config-get branch from e5ec450 to 7050230 Compare March 26, 2026 16:54

jfrancoa requested a review from Copilot March 26, 2026 16:55

Copilot started reviewing on behalf of jfrancoa March 26, 2026 16:56 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

weaviate/collections/classes/config.py Show resolved Hide resolved

dirkkul approved these changes Mar 26, 2026

View reviewed changes

jfrancoa merged commit bced996 into main Mar 27, 2026
216 of 242 checks passed

jfrancoa deleted the jose/fix-async-repl-config-get branch March 27, 2026 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: parse asyncConfig from replication config GET response#1996

fix: parse asyncConfig from replication config GET response#1996
jfrancoa merged 5 commits intomainfrom
jose/fix-async-repl-config-get

jfrancoa commented Mar 26, 2026

Uh oh!

orca-security-eu bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov-commenter commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jfrancoa commented Mar 26, 2026

Summary

Test plan

Uh oh!

orca-security-eu bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov-commenter commented Mar 27, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

orca-security-eu bot left a comment •

edited

Loading