Skip to content

Minor Object TTL bugs #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bevzzz merged 4 commits into from
Apr 2, 2026
Merged

Minor Object TTL bugs #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e734a2
fix(config): do not throw on missing ObjectTTL config
bevzzz Apr 2, 2026
37f2dee
fix(config): map object TTL deleteOn property names
bevzzz Apr 2, 2026
ffaae60
chore: lint & format
bevzzz Apr 2, 2026
edc7f2b
fix(config): apply update if no current is present
bevzzz Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/collections/config/classes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export class MergeWithExisting {
}

static objectTTL(current: WeaviateObjectTTLConfig, update: ObjectTTLConfigUpdate): WeaviateObjectTTLConfig {
if (current === undefined) throw Error('Object TTL config is missing from the class schema.');
if (current === undefined) return update;
return {
enabled: update.enabled ?? current.enabled,
deleteOn: update.deleteOn ?? current.deleteOn,
Expand Down
9 changes: 7 additions & 2 deletions src/collections/config/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,16 @@ class ConfigMapping {
return { enabled: false };
}
return {
...v,
enabled: v.enabled ?? false,
deleteOn: v.deleteOn,
deleteOn:
v.deleteOn == '_creationTimeUnix'
? 'creationTime'
: v.deleteOn == '_lastUpdateTimeUnix'
? 'updateTime'
: v.deleteOn,
defaultTTLSeconds: v.defaultTtl,
filterExpiredObjects: v.filterExpiredObjects,
...v,
};
}
static multiTenancy(v?: WeaviateMultiTenancyConfig): MultiTenancyConfig {
Expand Down
4 changes: 2 additions & 2 deletions test/collections/config/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@ describe('Testing of the collection.config namespace', () => {
const created = await collection.config.get();
expect(created.objectTTL).toBeDefined();
expect(created.objectTTL.enabled).toEqual(true);
expect(created.objectTTL.deleteOn).toEqual('_creationTimeUnix');
expect(created.objectTTL.deleteOn).toEqual('creationTime');
expect(created.objectTTL.defaultTTLSeconds).toEqual(120);

await collection.config.update({
Expand All @@ -1105,7 +1105,7 @@ describe('Testing of the collection.config namespace', () => {
const updated = await collection.config.get();
expect(updated.objectTTL).toBeDefined();
expect(updated.objectTTL.enabled).toEqual(true);
expect(updated.objectTTL.deleteOn).toEqual('_lastUpdateTimeUnix');
expect(updated.objectTTL.deleteOn).toEqual('updateTime');
expect(updated.objectTTL.defaultTTLSeconds).toEqual(400);

await collection.config.update({
Expand Down
Loading