make Compiler thread-safe by moving CodeBuilder to instance scope#87
Open
yaodingyd wants to merge 2 commits intowbond:masterfrom
Open
make Compiler thread-safe by moving CodeBuilder to instance scope#87yaodingyd wants to merge 2 commits intowbond:masterfrom
yaodingyd wants to merge 2 commits intowbond:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using compilers in a supposedly thread-safe way:
but running above code in a threadpool still running into issue
I think this is because each Compiler instance still reference to the same class field of _builder and _compiler, so their state get mutated cross thread
This change move these two fields to be instance property so when creating Compiler instance for each thread, each instance get isolated _build and _compiler
I don't have context on why we are keeping them this way so please correct me, appreciate more historical insights here