fix(cli): dynamic shell completion with API-driven resource names#292
Merged
Conversation
…y with API-driven resource names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gradient <TAB>actually works. The old static script registered against the capitalisedGradientapp name instead of thegradientbinary, which silently disabled completion entirely.organization cache add). Lookups honour the partial prefix and the currently selected organization.gradient completion <shell>re-invokes the binary withCOMPLETE=<shell>to emit the dynamic registration stub, keeping the Nix entry point unchanged.Test plan
cli/tests/completion.rs—gradient completion {bash,zsh}emits a script registered against the lowercasegradientbinary (-F _clap_complete_gradient gradient) and never referencesGradient.cli/src/commands/completion.rs— each completer returns resource names, respects the prefix, scopes to the selected org, and yields no candidates on a non-2xx response.cargo clippy --manifest-path cli/Cargo.toml --all-targetspasses clean.