fix(cli): decode caches list as bare array (#290)#291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gradient cache listprintedapi error (200): {...}instead of formatting the cache list.GET /cachesreturnsmessageas a bare array (server, docs, and frontend all agree), but the CLI connector'scaches().list()decodedPaginated<Vec<ListItem>>— a copy of the orgs/projects pattern. The shape mismatch madedecode<T>fail to parse the envelope and fall through to the raw-body error path, rendering a successful 200 as anapi error.caches().list()now returnsListResponse(Vec<ListItem>), matching the documentedListResponsecontract; thecache listcommand iterates the Vec directly (mirroringorgs subscriptions).No server, API-doc, or frontend changes needed — they already use the bare-array contract; only the connector was the outlier.
Fixes #290
Test plan
cargo test -p connector --test caches_api—list_caches_decodes_bare_arrayreplays the exact response from the bug report and asserts it decodes into aVec.gradient cache listagainst a server with at least one cache printsname: idlines instead of anapi error (200).