fix(web): surface 4xx + UI banner when evaluation start fails (#280)#281
Merged
Conversation
Member
Author
|
/gradient run |
Member
Author
|
/gradient run checks.x86_64-linux.gradient-cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core::sources::git::check_for_updatesfrom swallowingls_remote_headfailures; the polling loop already handlesErr(e)gracefully.SourceErrorto400with newcode: "repository_unreachable"onPOST /projects/{org}/{p}/evaluateandPOST /projects/{org}/{p}/check-repository, dropping the oldcommit_hash.is_empty()→ 500 fallback. Message includes the underlying git error.ProjectDetailComponentnow stores the API error in anerrorMessagesignal and renders an inline, dismissible.evaluation-errorbanner under the project header instead of failing silently.Closes #280.
Test plan
cargo check --workspace --testscleancargo clippy --workspace --tests -- -D warningscleannpx tsc --noEmitcleancargo test -p core --test git_remote(new testcheck_project_updates_propagates_unreachable_remote_error)pnpm --dir frontend exec ng test --watch=false(new specs inproject-detail.component.spec.ts)github:nix-community/bun2nixURL): backend returns400 repository_unreachable; UI banner shows the underlying git error.