C API Get module from an instance

[gumb0]

No description provided.

[codecov]

Codecov Report

Merging #599 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          63       63           
  Lines        9282     9294   +12     
=======================================
+ Hits         9121     9133   +12     
  Misses        161      161           

[chfast]

Suggested change

	const FizzyModule* fizzy_get_instance_module(FizzyInstance* instance);
	const FizzyModule* fizzy_instance_get_module(FizzyInstance* instance);

?

[axic]

I think this may be better wording, but we already have get_instance_memory, so I suggest we go with what is the PR and then rename all of them at once if we want.

[axic]

I guess this is only a "short term" workaround until we have C++ API to make all this work on the instance?

[gumb0]

I guess this is only a "short term" workaround until we have C++ API to make all this work on the instance?

I don't know, do you imagine that we would duplicate all module inspection functions for an instance?
To me it seems better to have functions that query module defnition (function/global types, table limits, memory limits etc.) only for a module.

[axic]

I guess this is only a "short term" workaround until we have C++ API to make all this work on the instance?

I don't know, do you imagine that we would duplicate all module inspection functions for an instance?
To me it seems better to have functions that query module defnition (function/global types, table limits, memory limits etc.) only for a module.

Probably this conversation originates from where Module was consumed by instantiate, and made this harder. Now that is not consumed anymore, do we actually need this helper? Fine to have it though.

[axic]

How about adding EXPECT_EQ(module, instance_module) ?

[gumb0]

I guess this is only a "short term" workaround until we have C++ API to make all this work on the instance?

I don't know, do you imagine that we would duplicate all module inspection functions for an instance?
To me it seems better to have functions that query module defnition (function/global types, table limits, memory limits etc.) only for a module.

Probably this conversation originates from where Module was consumed by instantiate, and made this harder. Now that is not consumed anymore, do we actually need this helper? Fine to have it though.

Module is still consumed.

[axic]

Module is still consumed.

Wasn't the whole point of the unique_ptr refactoring to make it not consume it and thus be reusable for multiple instances?

[gumb0]

Wasn't the whole point of the unique_ptr refactoring to make it not consume it and thus be reusable for multiple instances?

No, for that it would need to be changed to shared_ptr, which for now I think would be unnecessary complication / overhead.

The point was for FizzyModule* to simply represent both owned and unowned module, and to make this helper here possible.