Skip to content

Add Watchflow governance rules (4 rules, 3 high-priority) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkargatzis wants to merge 3 commits into from
Closed

Add Watchflow governance rules (4 rules, 3 high-priority) #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28302ec
chore: add Watchflow governance rules (3 rules)
dkargatzis Jan 24, 2026
a8257f9
chore: add Watchflow governance rules (4 rules)
dkargatzis Jan 24, 2026
955aa9c
chore: add Watchflow governance rules (4 rules)
dkargatzis Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 30 additions & 34 deletions .watchflow/rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,31 @@
rules:
# Essential Open Source Rules
- description: "Pull requests must have descriptive titles following conventional commit format"
enabled: true
severity: "medium"
event_types: ["pull_request"]
parameters:
title_pattern: "^feat|^fix|^docs|^style|^refactor|^test|^chore|^perf|^ci|^build|^revert"

- description: "New contributors require approval from at least one past contributor"
enabled: true
severity: "medium"
event_types: ["pull_request"]
parameters:
min_past_contributors: 1

- description: "Code changes must include corresponding tests"
enabled: true
severity: "medium"
event_types: ["pull_request"]
parameters:
pattern: "tests/.*\\.py$|test_.*\\.py$"
condition_type: "files_match_pattern"

- description: "Changes to critical files require review from code owners"
enabled: true
severity: "high"
event_types: ["pull_request"]

- description: "No direct pushes to main branch - all changes must go through PRs"
enabled: true
severity: "critical"
event_types: ["push"]
parameters:
allow_force_push: false
- description: 'code_owners: Enforce CODEOWNERS approval for critical paths to reduce
the 35% codeowner bypass rate, improving governance and code quality.'
enabled: true
severity: high
event_types:
- pull_request
parameters: {}
- description: 'required_workflows: Ensure CI passes before merge to maintain quality
and prevent regressions, supporting the existing CI/CD setup.'
enabled: true
severity: medium
event_types:
- pull_request
parameters: {}
Comment on lines +9 to +15
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Severity mismatch with PR objectives.

The PR description lists required_workflows as High priority, but the implementation uses medium severity. If CI passing is critical to prevent regressions, consider aligning the severity.

Suggested fix 
 - description: 'required_workflows: Ensure CI passes before merge to maintain quality
     and prevent regressions, supporting the existing CI/CD setup.'
   enabled: true
-  severity: medium
+  severity: high
   event_types:
   - pull_request
   parameters: {}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- description: 'required_workflows: Ensure CI passes before merge to maintain quality
and prevent regressions, supporting the existing CI/CD setup.'
enabled: true
severity: medium
event_types:
- pull_request
parameters: {}
- description: 'required_workflows: Ensure CI passes before merge to maintain quality
and prevent regressions, supporting the existing CI/CD setup.'
enabled: true
severity: high
event_types:
- pull_request
parameters: {}
🤖 Prompt for AI Agents 
In @.watchflow/rules.yaml around lines 9 - 15, The rule's severity is set to
"medium" but the PR and rule intent (required_workflows / description) indicate
this should be "high"; update the severity field in .watchflow/rules.yaml from
medium to high so the required_workflows rule enforces a high-priority check and
aligns with the PR objectives (look for the severity: medium entry associated
with the required_workflows description and change it to severity: high).

- description: 'required_labels: Enforce categorization of PRs (bug, enhancement,
etc.) to improve issue-diff alignment and clarity, addressing the 15% mismatch
rate.'
enabled: true
severity: medium
event_types:
- pull_request
parameters: {}
- description: 'title_pattern: Enforce Conventional Commits (feat:, fix:, etc.) to
clarify PR content and ensure meaningful change tracking, especially given zero
lines changed in many PRs.'
enabled: true
severity: medium
event_types:
- pull_request
parameters: {}
Comment on lines 1 to +31
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Missing rule for test coverage despite Critical severity finding.

The Health Analysis Report flags "0% new-code test coverage" as Critical severity, yet no rule enforces test requirements. According to the AI summary, the previous ruleset included "tests required for code changes" which was removed in this update.

Consider adding a rule to require tests for new code, especially given this is the highest-severity finding in the analysis:

Suggested addition 
- description: 'require_tests: Require test coverage for new code to prevent regressions
    and maintain code quality.'
  enabled: true
  severity: critical
  event_types:
  - pull_request
  parameters: {}
🤖 Prompt for AI Agents 
In @.watchflow/rules.yaml around lines 1 - 29, Add a new rule entry to the rules
list that enforces test coverage for new code to address the "0% new-code test
coverage" critical finding; create a rule with description 'require_tests' (or
similar), set enabled: true, severity: critical, event_types: [pull_request],
and include appropriate parameters (e.g., minimum new-code coverage threshold)
so PRs without required tests/coverage fail the check.