Make Dict Iota have proper protection from True Name writing#12
Open
Master-Bw3 wants to merge 2 commits into
Open
Make Dict Iota have proper protection from True Name writing#12Master-Bw3 wants to merge 2 commits into
Master-Bw3 wants to merge 2 commits into
Conversation
Owner
|
part of me thinks I should merge. but the other part of me knows that dictionary iotas are going to get punted in 1.20 in favor of replacing them with a "dictionary formatted list" due to all the issues I have had with dictionary iotas and them just being annoying to work with (would also make it easier for ducky to work with) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works by adding a mixin to
getTrueNameFromDatumto transform dictionary iotas into a list iota of both keys and values.Also removes the true name check when setting a value to a dictionary iota as it is no longer needed.