Skip to content

Turning editors into contributor section#453

Open
himorin wants to merge 588 commits intow3c:gh-pagesfrom
himorin:202502-contributors
Open

Turning editors into contributor section#453
himorin wants to merge 588 commits intow3c:gh-pagesfrom
himorin:202502-contributors

Conversation

@himorin
Copy link
Contributor

@himorin himorin commented Feb 10, 2025

As title, along with URL redirect fix.

@kidayasuo @xfq @r12a see middle part (lines 104-147 in new column). Do we have any other item to be mentioned here?

@himorin
Copy link
Contributor Author

himorin commented Feb 26, 2025

ah, just followed another spec I've working on, but no personal preference,,, e.g. https://www.w3.org/TR/webxr/#ack seeking others, mostly without affiliation for acknowledgments, removed them.

My feeling is that we should also acknowledge that the organisations involved allowed the individuals to work on this, which is the main reason for keeping the affiliation information.

If so, I would rather keep former format with combination of name and affiliation.
With writing separately something like we appreciate contributions of following organizations: xxx, additional meaning than affiliation could be included, and it is quite hard to check history over 20 years. We may ask Binn-sensei about any contribution, of course...

@r12a
Copy link
Contributor

r12a commented Feb 26, 2025

keep former format with combination of name and affiliation

I'm not sure what you mean by that. I was suggesting that we just add the affiliation (the one currently in the document's front matter) after the name in parens. But it's only a suggestion. If you prefer to leave as is, that's ok too.

@himorin
Copy link
Contributor Author

himorin commented Mar 3, 2025

@himorin himorin requested review from kidayasuo, r12a and xfq and removed request for kidayasuo, r12a and xfq March 3, 2025 01:20
<h1 class="title p-name" id="title">Requirements for Japanese Text Layout <br/><span lang="ja">日本語組版処理の要件(日本語版)</span></h1>

<div id="abstract">
<section id="abstract">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i remember correctly, we used the div markup here to avoid warning messages about using a section with no heading. You might want to check that out.

Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Thank you!

{ name: "<span lang='ja'>木田 泰夫</span> (Yasuo Kida)",
company: "Invited Expert",
w3cid: "40266" },
{ name: "Nathaniel McCully, (<span lang='ja'>第2版</span> 2nd edition)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include this @kidayasuo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this.
Yes, please add Nat. He contributed to the English translations as an editor.

Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The change looks good.

@himorin
Copy link
Contributor Author

himorin commented Mar 11, 2025

memo from 2025-03-11 JL-TF call, @kidayasuo will contact xfq and Richard about how to organize both editor field and contributors section.

@xfq
Copy link
Member

xfq commented May 14, 2025

This PR seems to have problems after @deniak force pushed the gh-pages branch, and commits cannot be displayed correctly. Maybe we can close and reopen a new PR?

@himorin
Copy link
Contributor Author

himorin commented May 21, 2025

@xfq per Feb/Mar JL-TF call, @kidayasuo as a chair gained and keeps a ball to write some note and proposal, so I'd defer to @kidayasuo to find a way which he prefers or thinks easy to work with.
but I don't quite understand why touching image resources would affect to index.html and script.js as making conflict. If force push changed something on these two files, itself might be an issue??

@xfq
Copy link
Member

xfq commented May 21, 2025

I don't quite understand why touching image resources would affect to index.html and script.js as making conflict. If force push changed something on these two files, itself might be an issue??

@deniak Do you know why?

@deniak
Copy link
Member

deniak commented May 22, 2025

I don't quite understand why touching image resources would affect to index.html and script.js as making conflict. If force push changed something on these two files, itself might be an issue??

@deniak Do you know why?

I think the issue is that the PR comes from @himorin's fork which still has the git LFS references. So the fork needs to be updated or the PR needs to be created directly from w3c/jlreq.

@xfq
Copy link
Member

xfq commented Jun 16, 2025

Any progress from @himorin @kidayasuo?

@kidayasuo
Copy link
Contributor

Ah, I have to decide who will be on the Editors list. Thank you for the heads up. I will reply in a few days.

@r12a
Copy link
Contributor

r12a commented Jun 19, 2025

Looking at the conflicts and large number of files changed, i suggest that we close this PR and create a new one with the actual proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants