Improve consistency of error handling in special handler failure path#394
Open
sage-mode-hunter wants to merge 3 commits into
Open
Conversation
Author
|
gentle ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves consistency in libucl error handling for special handler failures.
Problem
In the special handler execution path, when a handler fails, libucl unconditionally overwrites
parser->errwith:However, other parts of the parser (e.g. variable expansion and core parser logic) follow a different pattern where an existing error is preserved if already set.
This leads to inconsistent error ownership behavior across modules.
Change
The patch ensures that a previously set error from the special handler is not overwritten: