Skip to content

fix: bools where nil is interpreted as true can't have omitempty #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidgubler wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: bools where nil is interpreted as true can't have omitempty #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/vshn/v1/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ type Security struct {

// DeletionProtection blocks the deletion of the instance if it is enabled (enabled by default)
// +kubebuilder:default=true
DeletionProtection bool `json:"deletionProtection,omitempty"`
DeletionProtection bool `json:"deletionProtection"`

// AllowedGroups defines a list of Groups that have limited access to the instance namespace
AllowedGroups []string `json:"allowedGroups,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion apis/vshn/v1/dbaas_vshn_postgresql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ type VSHNPostgreSQLBackup struct {
// DeletionProtection will protect the instance from being deleted for the given retention time.
// This is enabled by default.
// +kubebuilder:default=true
DeletionProtection *bool `json:"deletionProtection,omitempty"`
DeletionProtection *bool `json:"deletionProtection"`

// DeletionRetention specifies in days how long the instance should be kept after deletion.
// The default is keeping it one week.
Expand Down
Loading