Skip to content

feat: add i18n/a11y localisation properties to select components#625

Merged
bendera merged 1 commit into
vscode-elements:pr-625-localizationfrom
wfabr:copilot/fix-hardcoded-english-strings
Jul 9, 2026
Merged

feat: add i18n/a11y localisation properties to select components#625
bendera merged 1 commit into
vscode-elements:pr-625-localizationfrom
wfabr:copilot/fix-hardcoded-english-strings

Conversation

@wfabr

@wfabr wfabr commented Jun 15, 2026

Copy link
Copy Markdown

User-visible strings and ARIA labels in the select components were hardcoded in English, which is an issue for translation. This pull request adds overridable properties with English defaults to VscodeSelectBase, VscodeMultiSelect, and VscodeSingleSelect.

New properties

VscodeSelectBase (inherited by both select components)

  • open-button-aria-label — ARIA label on the combobox toggle button (default: "Open the list of options")
  • no-options-text — empty-list placeholder (default: "No options")
  • create-option-prefix — prefix for the creatable entry (default: "Add", renders as Add "typed text")

VscodeMultiSelect

  • selected-text — suffix in the count badge (default: "Selected", renders as "3 Selected")
  • select-all-title — tooltip on the select-all button (default: "Select all")
  • deselect-all-title — tooltip on the deselect-all button (default: "Deselect all")
  • accept-button-text — label on the OK button (default: "OK")

Usage example

<vscode-multi-select
  open-button-aria-label="Öffne die Optionsliste"
  no-options-text="Keine Optionen"
  create-option-prefix="Hinzufügen"
  selected-text="Ausgewählt"
  select-all-title="Alle auswählen"
  deselect-all-title="Alle abwählen"
  accept-button-text="OK"
>
  ...
</vscode-multi-select>

All defaults are unchanged so there is no breaking change.

@bendera

bendera commented Jun 18, 2026

Copy link
Copy Markdown
Member

Thanks! I'll go thorugh it.

@bendera bendera changed the base branch from main to pr-625-localization July 9, 2026 20:54
@bendera bendera merged commit 533180e into vscode-elements:pr-625-localization Jul 9, 2026
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants