Skip to content

503 fix table resize bug #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendera merged 3 commits into from
Aug 26, 2025
Merged

503 fix table resize bug #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd2756c
fix: add guard to resize logic to check for existing cells before app…
pFornagiel Aug 26, 2025
7bcb87b
Add test for table resize fix
bendera Aug 26, 2025
7ab1383
Update readme
bendera Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Fixed

- Fixed issue where resizing threw an error if no rows were available.

## [2.2.0] - 2025-08-19

### Added
Expand Down
42 changes: 42 additions & 0 deletions dev/vscode-table/resize-empty-table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link
rel="stylesheet"
href="/node_modules/@vscode/codicons/dist/codicon.css"
id="vscode-codicon-stylesheet"
>
<script
type="module"
src="/node_modules/@vscode-elements/webview-playground/dist/index.js"
></script>
<script type="module" src="/dist/main.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<h1>Component demo</h1>
<main>
<vscode-demo>
<vscode-table resizable style="width: 500px">
<vscode-table-header>
<vscode-table-header-cell>Col 1</vscode-table-header-cell>
<vscode-table-header-cell>Col 2</vscode-table-header-cell>
</vscode-table-header>
<vscode-table-body>
<vscode-table-row>no data</vscode-table-row>
</vscode-table-body>
</vscode-table>
</vscode-demo>
</main>
</body>
</html>
23 changes: 22 additions & 1 deletion src/vscode-table/vscode-table.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {$, dragElement} from '../includes/test-helpers.js';
import {VscodeTable} from './index.js';
import {expect} from '@open-wc/testing';
import {expect, fixture, html} from '@open-wc/testing';

describe('vscode-table', () => {
it('is defined', () => {
Expand All @@ -13,4 +14,24 @@ describe('vscode-table', () => {

expect(() => el.remove()).not.to.throw();
});

it('should not throw on resize when no rows are present', async () => {
const el = await fixture(html`
<vscode-table resizable style="width: 500px">
<vscode-table-header>
<vscode-table-header-cell>Col 1</vscode-table-header-cell>
<vscode-table-header-cell>Col 2</vscode-table-header-cell>
</vscode-table-header>
<vscode-table-body>
<vscode-table-row>no data</vscode-table-row>
</vscode-table-body>
</vscode-table>
`);

async function testDrag() {
await dragElement($(el.shadowRoot!, '.sash-clickable'), 20);
}

expect(await testDrag()).not.to.throw;
});
});
2 changes: 1 addition & 1 deletion src/vscode-table/vscode-table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ export class VscodeTable extends VscElement {
this._headerCellsToResize[1].style.width = nextColCss;
}

if (resizeBodyCells) {
if (resizeBodyCells && this._cellsToResize[0]) {
this._cellsToResize[0].style.width = prevColCss;

if (this._cellsToResize[1]) {
Expand Down