Support Vivobook S 16 (M5606K) with dynamic report_id configuration#2
Support Vivobook S 16 (M5606K) with dynamic report_id configuration#2owsma wants to merge 2 commits intovrgb-dev:mainfrom
Conversation
|
Really appreciate you taking the time to dig into this and put together a patch on your S 16. This is exactly the kind of hardware feedback I was hoping to get early on. The logs and notes you included are super helpful, especially confirming behavior on a different Vivobook model. I’m going to review this over the next few days (I'm new to the open source world as well, it's all good) and adapt the approach into the main branch in a way that keeps the current path stable while expanding support for your model. Thanks again for contributing and for testing on your hardware. It helps a lot, and is exciting to see that this script can work on other laptops. |
|
Thanks again for your patch and the logs. I've now integrated your report ID findings into the main script in a slightly cleaner way by moving VRGB to a supported-device mapping, while keeping the existing profile support intact. I've validated the updated code on my S5406SA S14, and the new code is now on main (v.0.3.1). When you get a chance, could you pull the latest v.0.3.1 from main and test it on your M5606K S16? I'd love confirmation that everything works (status, set, brightness, off, restore, auto on/off, etc) on your system. You taking the time to test your system out and contribute really made this device support possible, so I really appreciate your help. |
Summary
If the relevant HID on the Vivobook S 16 (M5606K) is detected, the correct firmware and color report_ids are set.
Tried to keep the patch as minimal as possible - sorry for setting global variables inside a function. Wasn't sure what to bump the version to or how I should edit the README as I'm just getting started with open source.
Tested on my M5606K only.
Debug logs before merge
vrgb --debug status:Debug logs after merge
vrgb --debug status:vrgb --debug set FF0000 100: