-
Notifications
You must be signed in to change notification settings - Fork 0
Done module-bash #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| esac | ||
| echo "Error.." | ||
| exit 1 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two flags input test not passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this one too
| else | ||
| echo "Hello, $1!" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
| else | ||
| echo the searched PATH is unexisting | ||
| fi | ||
| done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 existing paths 2 existing FILES tests are failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The outputs are identical, though don't need to do anything
| else | ||
| exit 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
| basename $files | ||
| grep -n $pattern $files | cut -f1 -d":" | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No args and Without first arg tests are failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is wrong, need to update!!
|
|
||
| } | ||
|
|
||
| map ${@} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
| else | ||
| head -$1 resourses/surnames.txt | grep -v 'Q-Chem' | sed 's/-//;s/.$//' | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test on 0 lines returns error and Test on 2 lines return empty string are failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed tests and ex07.sh
| grep '^[a-zA-Z0-9]\+@[a-zA-Z0-9]\+\.[a-z]\{2,\}' $2 | ||
| ;; | ||
|
|
||
| esac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
| echo $(awk 'END{print NR}' $1) $1 | ||
| exit 0 | ||
| fi | ||
| exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with directory and with 2 files tests are failed
| arr[$i]=$(grep -o $i $1 | wc -l) | ||
| result+=' '${arr[$i]}' '${nums[$i]} | ||
| done | ||
| echo $result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests except first one are failed, fixed test is here https://github.com/vpetrusenko/module-bash/pull/4/files#diff-3e35ef4d05c4325d58bedc87bb4e27eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this one too
No description provided.