Done module-bash #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetrusenko
requested changes
Jun 21, 2018
| echo "Hello, $1!" | ||
| else | ||
| echo "Hello, World!" | ||
| fi |
| @@ -0,0 +1,17 @@ | |||
| #!/bin/bash | |||
| ls_out=$(ls -R | xargs -n1) | |||
| echo "$ls_out" > .assist | |||
Owner
There was a problem hiding this comment.
Please do it without assist file creation, solution of this ex is more easy than your, one cycle and only one var
| if [ -z $1 ]; then | ||
| exit 1 | ||
| fi | ||
| touch .f |
Owner
There was a problem hiding this comment.
The same, do it without file creation
| #!/usr/bin/bash | ||
| if [ -z $1 ] || [ -z $2 ]; then | ||
| exit 1 | ||
| fi |
Owner
There was a problem hiding this comment.
again please do it without file creation
| *) | ||
| ;; | ||
| esac | ||
| echo "$res" |
| eval "$com $i" | ||
| done | ||
| } | ||
|
|
| echo "$res" | ||
| else | ||
| echo "" | ||
| fi |
Owner
There was a problem hiding this comment.
Test on 0 lines returns error and Test on 2 lines return empty string tests are failed
| grep -Po '(^|\t)[A-Za-z0-9\.]+@[A-Za-z0-9\.]+\.[A-Za-z0-9\.]+' $2 | ||
| else | ||
| exit 1 | ||
| fi |
| for i in $@ | ||
| do | ||
| echo "$(awk 'END{print NR}' $i) $i" | ||
| done |
vpetrusenko
requested changes
Jun 21, 2018
| ten=$(grep -o "9" resources/digitfile.txt | wc -l)" nines" | ||
|
|
||
| echo $zer, $ones, $twos, $th, $ft, $fif, $six, $sev, $nin, $ten | ||
|
|
Owner
There was a problem hiding this comment.
all tests are failed, fixed test is here https://github.com/vpetrusenko/module-bash/pull/4/files#diff-3e35ef4d05c4325d58bedc87bb4e27eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.