refactor(usb-drive): use optional instead of nullable in BlockDeviceInfo#8128
Merged
eventualbuddha merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
eventualbuddha
force-pushed
the
refactor/use-optional-instead-of-nullable-in-blockdeviceinfo
branch
from
d8662a3 to
a99e5d6
Compare
…al label Now that `BlockDeviceInfo.label` is `string | undefined` instead of `string | null`, the `?? undefined` coalescing is redundant and was causing an uncovered branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
carolinemodic
approved these changes
Mar 18, 2026
eventualbuddha
deleted the
refactor/use-optional-instead-of-nullable-in-blockdeviceinfo
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extracted from #8057
Refs #7897
Optional fields fits better with the interfaces we typically use in VxSuite.
Demo Video or Screenshot
n/a
Testing Plan
Automated tests.