fix(admin): use full usbDrives[0] object as listPotentialElectionPackagesOnUsbDrive query key#8122
Merged
eventualbuddha merged 3 commits intobrian/multi-usb-apifrom Mar 17, 2026
Merged
Conversation
2 tasks
|
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on multi-USB drive API for VxAdmin implementation
fix(admin): use full usbDrives[0] object as listPotentialElectionPackagesOnUsbDrive query key
Mar 17, 2026
eventualbuddha
approved these changes
Mar 17, 2026
eventualbuddha
added a commit
that referenced
this pull request
Mar 17, 2026
…agesOnUsbDrive query key (#8122)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #8057: the
queryKeyforlistPotentialElectionPackagesOnUsbDriveonly keyed offmount.type, so swapping to a different drive that was alsomountedwouldn't trigger a refetch.Overview
Use the full
usbDrives[0]object as the query key so any drive identity change (devPath,mountPoint, etc.) produces a distinct key and forces React Query to refetch.Demo Video or Screenshot
Testing Plan
Checklist
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.