chore(deps): update @typscript-eslint/* packages

apps/admin/frontend/src/screens/contest_adjudication_screen.test.tsx

@@ -37,7 +37,7 @@ beforeEach(() => {
   apiMock = createApiMock();
   // JSDOM does not implement scrollIntoView, so we define it as a no-op
   // to prevent tests from throwing when components attempt to scroll elements.
-  window.HTMLElement.prototype.scrollIntoView = function () {};
+  window.HTMLElement.prototype.scrollIntoView = () => {};
 });
 
 afterEach(() => {

apps/admin/frontend/src/utils/reporting.test.ts

@@ -288,12 +288,12 @@ test('generateReportPdfFilename when too long', () => {
     ...originalElection,
     precincts: [
       {
-        ...originalElection.precincts[0]!,
+        ...originalElection.precincts[0],
         id: 'precinct-1',
         name: 'A'.repeat(256),
       },
       {
-        ...originalElection.precincts[1]!,
+        ...originalElection.precincts[1],
         id: 'precinct-2',
         name: 'Precinct 2',
       },

apps/design/backend/.eslintrc.json

@@ -14,7 +14,9 @@
     {
       "files": ["migrations/**"],
       "rules": {
-        "vx/gts-module-snake-case": "off"
+        "vx/gts-module-snake-case": "off",
+        "@typescript-eslint/no-require-imports": "off",
+        "@typescript-eslint/no-var-requires": "off"
       }
     }
   ]

apps/design/backend/migrations/1742941957696_regenerate-duplicate-ids.js

@@ -1,5 +1,4 @@
 /* eslint-disable vx/gts-object-literal-types */
-/* eslint-disable @typescript-eslint/no-var-requires */
 const { hasSplits } = require('@votingworks/types');
 const { generateId } = require('../build/utils.js');
 

apps/design/backend/migrations/1742944839600_election-content-tables.js

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 const { throwIllegalValue } = require('@votingworks/basics');
 const { hasSplits } = require('@votingworks/types');
 const { PgLiteral } = require('node-pg-migrate');

apps/design/backend/migrations/1756159958924_organizations-table.js

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 const { ManagementClient } = require('auth0');
 const { assertDefined } = require('@votingworks/basics');
 

apps/pollbook/backend/src/barcode_scanner/client.ts

@@ -42,7 +42,7 @@ export async function connectToBarcodeScannerSocket(
   while (new Date().getTime() - connectStart.getTime() < timeoutMs) {
     try {
       return await tryConnect(logger);
-    } catch (e) {
+    } catch {
       await sleep(UDS_CONNECTION_ATTEMPT_DELAY_MS);
     }
   }

apps/pollbook/backend/src/receipts/receipt_helpers.tsx

@@ -2,8 +2,7 @@ import styled from 'styled-components';
 import { throwIllegalValue } from '@votingworks/basics';
 import { format } from '@votingworks/utils';
 import { DivBreakWord, IconName, Icons, SpanBreakWord } from '@votingworks/ui';
-import { Election } from '@votingworks/types';
-import { Voter, VoterCheckIn } from '@votingworks/types';
+import { Election, Voter, VoterCheckIn } from '@votingworks/types';
 
 export const StyledReceipt = styled.div``;
 

apps/pollbook/backend/src/street_helpers.ts

@@ -1,10 +1,10 @@
-import { safeParseInt } from '@votingworks/types';
-import { Optional } from '@votingworks/basics';
 import {
+  safeParseInt,
   VoterAddressChangeRequest,
   ValidStreetInfo,
   VoterRegistrationRequest,
 } from '@votingworks/types';
+import { Optional } from '@votingworks/basics';
 import { isVoterNameChangeValid } from './voter_helpers';
 
 export function maybeGetStreetInfoForAddress(

apps/pollbook/backend/test/test_helpers.ts

@@ -144,7 +144,7 @@ export function syncEventsFromTo(
       });
       allEvents.push(...events);
       keepSyncing = hasMore;
-    } catch (error) {
+    } catch {
       break;
     }
   }

docs/exercises/01-iteration/06-json.exercise.ts

@@ -29,12 +29,12 @@ interface Contact {
   email: string;
 }
 
-function* getListOfContactsFromDatabase(): Generator<Contact> {
+async function* getListOfContactsFromDatabase(): AsyncGenerator<Contact> {
   for (let i = 0; i < 100_000; i += 1) {
-    yield {
+    yield await Promise.resolve({
       name: `Person ${i}`,
       email: `person${i}@example.com`,
-    };
+    });
   }
 }
 

libs/auth/scripts/src/generate_machine_label_qr_code_contents.ts

@@ -104,7 +104,7 @@ async function generateMachineLabelQrCodeContents({
       messageSignature,
       publicKey,
     });
-  } catch (error) {
+  } catch {
     throw new Error(
       "Unable to verify signature. Make sure that you're using the correct private key."
     );

libs/basics/src/iterators/iter.test.ts

@@ -94,6 +94,7 @@ test('iter is iterable', () => {
 test('iter is async iterable', async () => {
   expect(iter([]).async()[Symbol.asyncIterator]).toBeDefined();
 
+  // eslint-disable-next-line @typescript-eslint/await-thenable
   for await (const item of iter([1, 2, 3])) {
     expect(typeof item).toEqual('number');
   }

libs/db/src/client.ts

@@ -4,7 +4,7 @@ import { Buffer } from 'node:buffer';
 import { createHash } from 'node:crypto';
 import makeDebug from 'debug';
 import * as fs from 'node:fs';
-import Database = require('better-sqlite3');
+import Database from 'better-sqlite3';
 import { dirname, join } from 'node:path';
 
 type Database = Database.Database;
@@ -54,7 +54,7 @@ export class Client {
     private readonly logger: BaseLogger,
     private readonly schemaPath?: string,
     private readonly connectionOptions?: DbConnectionOptions
-  ) {}
+  ) { }
 
   /**
    * Gets the path to the SQLite database file.

libs/eslint-plugin-vx/package.json

@@ -28,8 +28,8 @@
   },
   "packageManager": "pnpm@8.15.5",
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "6.7.0",
-    "@typescript-eslint/utils": "6.7.0",
+    "@typescript-eslint/eslint-plugin": "8.40.0",
+    "@typescript-eslint/utils": "8.40.0",
     "comment-parser": "^1.4.0",
     "eslint-config-airbnb": "^19.0.4",
     "eslint-config-airbnb-base": "^15.0.0",
@@ -45,7 +45,7 @@
   "devDependencies": {
     "@types/node": "20.17.31",
     "@types/react": "18.3.3",
-    "@typescript-eslint/rule-tester": "^6.7.0",
+    "@typescript-eslint/rule-tester": "8.40.0",
     "@vitest/coverage-istanbul": "^3.1.1",
     "eslint-plugin-vitest": "^0.5.4",
     "is-ci-cli": "2.2.0",

libs/eslint-plugin-vx/src/rules/gts_array_type_style.ts

@@ -11,8 +11,6 @@ const rule: TSESLint.RuleModule<
     docs: {
       description:
         'Recommends using short form T[] for simple array types (containing only alphanumeric characters and dots). Recommends using long form Array<T> for complex array types.',
-      recommended: 'stylistic',
-      requiresTypeChecking: false,
     },
     fixable: 'code',
     messages: {

libs/eslint-plugin-vx/src/rules/gts_constants.ts

@@ -10,8 +10,6 @@ const rule: TSESLint.RuleModule<
   meta: {
     docs: {
       description: 'Enforces GTS JSDoc rules.',
-      recommended: 'stylistic',
-      requiresTypeChecking: false,
     },
     fixable: 'code',
     messages: {

libs/eslint-plugin-vx/src/rules/gts_direct_module_export_access_only.ts

@@ -9,8 +9,6 @@ const rule: TSESLint.RuleModule<'directAccessOnly', readonly unknown[]> =
       docs: {
         description:
           'Directly access module import properties rather than passing it around.',
-        recommended: 'stylistic',
-        requiresTypeChecking: false,
       },
       messages: {
         directAccessOnly:

libs/eslint-plugin-vx/src/rules/gts_func_style.ts

@@ -18,8 +18,6 @@ const rule: TSESLint.RuleModule<'useFunctionDeclaration', readonly unknown[]> =
       docs: {
         description:
           'Use `function foo() { ... }` to declare named functions, including functions in nested scopes, e.g. within another function.',
-        recommended: 'stylistic',
-        requiresTypeChecking: false,
       },
       fixable: 'code',
       messages: {

libs/eslint-plugin-vx/src/rules/gts_identifiers.ts

@@ -29,8 +29,6 @@ const rule: TSESLint.RuleModule<
     docs: {
       description:
         'Disallows use of $ in identifiers, except when aligning with naming conventions for third party frameworks.',
-      recommended: 'stylistic',
-      requiresTypeChecking: false,
     },
     messages: {
       noAbbreviations: `Treat abbreviations like acronyms in names as whole words`,

libs/eslint-plugin-vx/src/rules/gts_jsdoc.ts

@@ -31,8 +31,6 @@ const rule: TSESLint.RuleModule<
   meta: {
     docs: {
       description: 'Enforces GTS JSDoc rules.',
-      recommended: 'stylistic',
-      requiresTypeChecking: false,
     },
     fixable: 'code',
     messages: {

libs/eslint-plugin-vx/src/rules/gts_module_snake_case.ts

@@ -24,8 +24,6 @@ const rule: TSESLint.RuleModule<'useSnakeCase', readonly unknown[]> =
     meta: {
       docs: {
         description: 'Requires the use of `snake_case` for module file names.',
-        recommended: 'stylistic',
-        requiresTypeChecking: false,
       },
       messages: {
         useSnakeCase:

libs/eslint-plugin-vx/src/rules/gts_no_array_constructor.ts

@@ -8,8 +8,6 @@ const rule: TSESLint.RuleModule<'noArrayConstructor', readonly unknown[]> =
     meta: {
       docs: {
         description: 'Disallows using the `Array` constructor.',
-        recommended: 'strict',
-        requiresTypeChecking: false,
       },
       fixable: 'code',
       messages: {

libs/eslint-plugin-vx/src/rules/gts_no_const_enum.ts

@@ -8,8 +8,6 @@ const rule: TSESLint.RuleModule<'noConstEnum', readonly unknown[]> = createRule(
     meta: {
       docs: {
         description: 'Disallows use of `const enum`; use `enum` instead.',
-        recommended: 'strict',
-        requiresTypeChecking: false,
       },
       messages: {
         noConstEnum: 'Use `enum` instead of `const enum`.',

libs/eslint-plugin-vx/src/rules/gts_no_default_exports.ts

@@ -10,8 +10,6 @@ const rule: TSESLint.RuleModule<
   meta: {
     docs: {
       description: 'Disallows default exports',
-      recommended: 'stylistic',
-      requiresTypeChecking: false,
     },
     fixable: 'code',
     messages: {
@@ -79,7 +77,12 @@ const rule: TSESLint.RuleModule<
             node.parent.type === AST_NODE_TYPES.ExportNamedDeclaration
         );
 
-        if (node.local.name === 'default' && node.exported.name !== 'default') {
+        if (
+          node.local.type === AST_NODE_TYPES.Identifier &&
+          node.exported.type === AST_NODE_TYPES.Identifier &&
+          node.local.name === 'default' &&
+          node.exported.name !== 'default'
+        ) {
           context.report({
             node: node.parent,
             messageId: 'noDefaultExports',

libs/eslint-plugin-vx/src/rules/gts_no_for_in_loop.ts

@@ -8,8 +8,6 @@ const rule: TSESLint.RuleModule<'noForInLoop', readonly unknown[]> = createRule(
     meta: {
       docs: {
         description: 'Disallows use of `for-in` loops',
-        recommended: 'strict',
-        requiresTypeChecking: false,
       },
       fixable: 'code',
       messages: {

libs/eslint-plugin-vx/src/rules/gts_no_foreach.ts

@@ -89,8 +89,6 @@ const rule: TSESLint.RuleModule<'noForEach', readonly unknown[]> = createRule({
     docs: {
       description:
         'Disallows use of `Array.prototype.forEach`, `Set.prototype.forEach`, and `Map.prototype.forEach`',
-      recommended: 'stylistic',
-      requiresTypeChecking: true,
     },
     messages: {
       noForEach:

libs/eslint-plugin-vx/src/rules/gts_no_import_export_type.ts

@@ -10,8 +10,6 @@ const rule: TSESLint.RuleModule<
   meta: {
     docs: {
       description: 'Disallows use of `import type` and `export type`',
-      recommended: 'strict',
-      requiresTypeChecking: false,
     },
     fixable: 'code',
     messages: {
@@ -72,9 +70,9 @@ const rule: TSESLint.RuleModule<
 
       if (
         reference.identifier.parent.type !==
-          AST_NODE_TYPES.ExportAllDeclaration &&
+        AST_NODE_TYPES.ExportAllDeclaration &&
         reference.identifier.parent.parent.type !==
-          AST_NODE_TYPES.ExportNamedDeclaration
+        AST_NODE_TYPES.ExportNamedDeclaration
       ) {
         return false;
       }
@@ -149,8 +147,10 @@ const rule: TSESLint.RuleModule<
         // export type { foo }
         if (
           allowReexport &&
-          node.specifiers.every((specifier) =>
-            isReexportOnly(specifier.local.name)
+          node.specifiers.every(
+            (specifier) =>
+              specifier.local.type === AST_NODE_TYPES.Identifier &&
+              isReexportOnly(specifier.local.name)
           )
         ) {
           return;

libs/eslint-plugin-vx/src/rules/gts_no_private_fields.ts

@@ -11,8 +11,6 @@ const rule: TSESLint.RuleModule<'noPrivateFields', readonly unknown[]> =
     meta: {
       docs: {
         description: 'Disallows use of private fields aka private identifiers',
-        recommended: 'strict',
-        requiresTypeChecking: false,
       },
       messages: {
         noPrivateFields: `Do not use private fields; instead, use TypeScript's visibility annotations`,

libs/eslint-plugin-vx/src/rules/gts_no_public_class_fields.ts

@@ -7,8 +7,6 @@ const rule: TSESLint.RuleModule<'noPublicClassFields', readonly unknown[]> =
     meta: {
       docs: {
         description: 'Disallows public class fields.',
-        recommended: 'strict',
-        requiresTypeChecking: false,
       },
       messages: {
         noPublicClassFields:

libs/eslint-plugin-vx/src/rules/gts_no_public_modifier.ts

@@ -9,8 +9,6 @@ const rule: TSESLint.RuleModule<'noPublicModifier', readonly unknown[]> =
       docs: {
         description:
           'Disallows use of `public` accessibility modifiers on class properties',
-        recommended: 'strict',
-        requiresTypeChecking: false,
       },
       fixable: 'code',
       messages: {

libs/eslint-plugin-vx/src/rules/gts_no_return_type_only_generics.ts

@@ -12,8 +12,6 @@ const rule: TSESLint.RuleModule<
     docs: {
       description:
         'Disallows generics in functions where the only use is in the return type',
-      recommended: 'strict',
-      requiresTypeChecking: true,
     },
     messages: {
       noReturnTypeOnlyGenerics:
@@ -29,7 +27,7 @@ const rule: TSESLint.RuleModule<
       node: TSESTree.FunctionLike,
       typeParameter: TSESTree.TSTypeParameter
     ): boolean {
-      const scope = context.getScope();
+      const scope = context.sourceCode.getScope(typeParameter.name);
       const variable = scope.set.get(typeParameter.name.name);
       let typeParameterReferencedByFunctionParamType = false;
       let typeParameterReferencedByFunctionReturnType = false;

libs/eslint-plugin-vx/src/rules/gts_no_unnecessary_has_own_property_check.ts

@@ -10,8 +10,6 @@ const rule: TSESLint.RuleModule<
     docs: {
       description:
         'Flags unnecessary `hasOwnProperty` checks inside `for-of` loops',
-      recommended: 'strict',
-      requiresTypeChecking: false,
     },
     messages: {
       noUnnecessaryHasOwnPropertyCheck:

libs/eslint-plugin-vx/src/rules/gts_object_literal_types.ts

@@ -17,8 +17,6 @@ const rule: TSESLint.RuleModule<
     docs: {
       description:
         'Requires type annotations instead of type assertions on object literals',
-      recommended: 'strict',
-      requiresTypeChecking: false,
     },
     messages: {
       noObjectLiteralTypeAssertions:

libs/eslint-plugin-vx/src/rules/gts_parameter_properties.ts

@@ -41,8 +41,6 @@ const rule: TSESLint.RuleModule<
   meta: {
     docs: {
       description: 'Use parameter properties for concise class initializers',
-      recommended: 'stylistic',
-      requiresTypeChecking: false,
     },
     messages: {
       useParameterProperties:

libs/eslint-plugin-vx/src/rules/gts_safe_number_parse.ts

@@ -9,8 +9,6 @@ const rule: TSESLint.RuleModule<
   meta: {
     docs: {
       description: 'Requires using a safe number parser',
-      recommended: 'strict',
-      requiresTypeChecking: false,
     },
     messages: {
       useSafeParseNumber: 'Use `safeParseNumber` to parse numbers.',