3396-pool-delete-on-pruning: Support for changes #3485

src/Npgsql/NpgsqlConnection.cs

@@ -189,15 +189,6 @@ void GetPoolAndSettings()
             var newPool = new ConnectorPool(Settings, canonical);
             _pool = PoolManager.GetOrAdd(canonical, newPool);
 
-            // If the pool we created was the one that ended up being stored we need to increment the appropriate counter.
-            // Avoids a race condition where multiple threads will create a pool but only one will be stored.
-            if (_pool == newPool)
-            {
-                // If the pool we created was the one that ended up being stored we need to increment the appropriate counter.
-                // Avoids a race condition where multiple threads will create a pool but only one will be stored.
-                NpgsqlEventSource.Log.PoolCreated(newPool);
-            }
-
             _pool = PoolManager.GetOrAdd(_connectionString, _pool);
         }
 

src/Npgsql/NpgsqlEventSource.cs

@@ -89,6 +89,14 @@ internal void PoolCreated(ConnectorPool pool)
             }
         }
 
+        internal void PoolDeleted(ConnectorPool pool)
+        {
+            lock (_poolsLock)
+            {
+                _pools.Remove(pool);
+            }
+        }
+
         internal void MultiplexingBatchSent(int numCommands, int waits, Stopwatch stopwatch)
         {
             // TODO: CAS loop instead of 4 separate interlocked operations?

src/Npgsql/PoolManager.cs

@@ -76,6 +76,9 @@ internal static ConnectorPool GetOrAdd(string key, ConnectorPool pool)
                 _pools[_nextSlot].Key = key;
                 _pools[_nextSlot].Pool = pool;
                 Interlocked.Increment(ref _nextSlot);
+
+                NpgsqlEventSource.Log.PoolCreated(pool);
+
                 return pool;
             }
         }
@@ -110,7 +113,9 @@ internal static void Delete(ConnectorPool pool)
 
                 Interlocked.Decrement(ref _nextSlot);
                 _pools = newPools;
-            }    
+
+                NpgsqlEventSource.Log.PoolDeleted(pool);
+            }
         }
 
         internal static void Clear(string connString)
@@ -151,6 +156,13 @@ internal static void Reset()
             lock (Lock)
             {
                 ClearAll();
+                var pools = _pools;
+                foreach (var (_, pool) in pools)
+                {
+                    if (pool != null)
+                        NpgsqlEventSource.Log.PoolDeleted(pool);
+                }
+
                 _pools = new (string, ConnectorPool)[InitialPoolsSize];
                 _nextSlot = 0;
             }