Add JSON Schema for VA Form 29-4125a#3
Draft
voidspooks wants to merge 1 commit into
Draft
Conversation
Generated by Optimus (https://github.com/aquia-inc/optimus). All files require human review before merging. Files: - src/schemas/29-4125a/schema.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New schema — VA Form 29-4125a
Summary
This PR introduces the JSON schema for VA Form 29-4125a (Claim for One Sum Payment), used in VA life insurance benefit claims. The schema is defined using JSON Schema Draft-04 and enforces
additionalProperties: falseat the top level for strict validation.Key schema details include:
fullName,ssn, and at least one additional definition (truncated in artifact). ThefullNamedefinition requiresfirstandlastfields (with character length constraints), and treatsmiddleas optional/nullable. Thessndefinition enforces a strict 9-digit numeric pattern with no dashes.minLength,maxLength, andpatternconstraints to reflect form field requirements.exampleannotations are included on individual properties to aid developer understanding and documentation generation.buildDefinitionReferencehelper is used to generate$refpointers to shared definitions, promoting reuse across the schema.Files
src/schemas/29-4125a/schema.jsNotes for reviewer
package.jsonbackend-review-groupas a reviewerssndefinition uses a 9-digit numeric pattern (^[0-9]{9}$) — confirm this aligns with how the vets-api backend expects SSN data (no dashes, no formatting).middlename field is typed as['string', 'null'], indicating it is intentionally nullable; verify this matches frontend form behavior.fullNameandssn(truncated in the artifact) introduce conditionalrequiredfields oroneOf/anyOfbranching that may need extra review attention.propertiesand root-levelrequiredfields accurately reflect the paper form's mandatory fields for VA Form 29-4125a.Pull Requests to update the schema in related repositories