Skip to content

Add JSON Schema for VA Form 29-4125a#3

Draft
voidspooks wants to merge 1 commit into
masterfrom
optimus/29-4125a-schema-20260427T132038Z-10cf
Draft

Add JSON Schema for VA Form 29-4125a#3
voidspooks wants to merge 1 commit into
masterfrom
optimus/29-4125a-schema-20260427T132038Z-10cf

Conversation

@voidspooks

Copy link
Copy Markdown
Owner

⚠️ AI-Generated PR — This pull request was automatically generated by Optimus. All code requires human review and testing before merging.

New schema — VA Form 29-4125a

Summary

This PR introduces the JSON schema for VA Form 29-4125a (Claim for One Sum Payment), used in VA life insurance benefit claims. The schema is defined using JSON Schema Draft-04 and enforces additionalProperties: false at the top level for strict validation.

Key schema details include:

  • Definitions block with reusable types: fullName, ssn, and at least one additional definition (truncated in artifact). The fullName definition requires first and last fields (with character length constraints), and treats middle as optional/nullable. The ssn definition enforces a strict 9-digit numeric pattern with no dashes.
  • Field-level validation via minLength, maxLength, and pattern constraints to reflect form field requirements.
  • example annotations are included on individual properties to aid developer understanding and documentation generation.
  • A buildDefinitionReference helper is used to generate $ref pointers to shared definitions, promoting reuse across the schema.

Note: The artifact summary is truncated at 1000 characters. Reviewers should inspect the full schema.js file for remaining definitions, top-level properties, and any required fields declared at the root object level.

Files

  • src/schemas/29-4125a/schema.js

Notes for reviewer

  • Please ensure you have incremented the version in package.json
  • Please add backend-review-group as a reviewer
  • The ssn definition uses a 9-digit numeric pattern (^[0-9]{9}$) — confirm this aligns with how the vets-api backend expects SSN data (no dashes, no formatting).
  • The middle name field is typed as ['string', 'null'], indicating it is intentionally nullable; verify this matches frontend form behavior.
  • Confirm whether any additional definitions beyond fullName and ssn (truncated in the artifact) introduce conditional required fields or oneOf/anyOf branching that may need extra review attention.
  • Validate that all top-level properties and root-level required fields accurately reflect the paper form's mandatory fields for VA Form 29-4125a.

Pull Requests to update the schema in related repositories

  • vets-api: pending
  • vets-website: pending

Generated by Optimus (https://github.com/aquia-inc/optimus).
All files require human review before merging.

Files:
- src/schemas/29-4125a/schema.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant