Add JSON Schema for VA Form 22-1990n#2
Draft
voidspooks wants to merge 1 commit into
Draft
Conversation
Generated by Optimus (https://github.com/aquia-inc/optimus). All files require human review before merging. Files: - src/schemas/22-1990n/schema.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New schema — VA Form 22-1990n
Summary
This PR introduces the JSON schema for VA Form 22-1990n (Application for VA Education Benefits Under the National Call to Service (NCS) Program). The schema covers core applicant information including:
first,last, required;middleas a single nullable character matching^[A-Za-z]$), Social Security Number (9-digit string, no hyphens, validated via pattern^\d{9}$), and date fields conforming to ISO 8601 (format: date).buildDefinitionReferencehelper using JSON Schema$refpointers to#/definitions/*, promoting consistency across field reuse.additionalProperties: false, enforcing that only explicitly declared properties are accepted.http://json-schema.org/draft-04/schema#, consistent with existing schemas in this repository.Notable patterns include nullable typed fields (e.g.,
type: ['string', 'null']for middle name) and length constraints applied alongside pattern validation for SSN and name fields.Files
src/schemas/22-1990n/schema.jsNotes for reviewer
package.jsonbackend-review-groupas a reviewermiddlename field usestype: ['string', 'null']withmaxLength: 1— confirm this aligns with downstream vets-api expectations for nullable single-character initials.datedefinition — please verify that all remaining top-levelpropertiesand anyrequiredfields on the root object are complete and accurate before merging.Pull Requests to update the schema in related repositories