Skip to content

Adding default password criteria to sample config#95

Open
minhducsun2002 wants to merge 2 commits intovnma0:masterfrom
minhducsun2002:password-condition
Open

Adding default password criteria to sample config#95
minhducsun2002 wants to merge 2 commits intovnma0:masterfrom
minhducsun2002:password-condition

Conversation

@minhducsun2002
Copy link
Copy Markdown
Contributor

This enables setting custom rules for passwords.

However, whether this option is mandatory in the configuration is up to upstream maintainers.

@dungwinux
Copy link
Copy Markdown
Member

@minhducsun2002, this can be quite messy, you know

@dungwinux dungwinux added the question Further information is requested label Oct 10, 2019
@minhducsun2002
Copy link
Copy Markdown
Contributor Author

minhducsun2002 commented Oct 10, 2019

Hardcoding checks in the web app is not a good way to implement criteria for strings.

The more preferred method is a regular expression.

@dungwinux
Copy link
Copy Markdown
Member

But hey, I can't find your implementation. There's only sample change

@minhducsun2002
Copy link
Copy Markdown
Contributor Author

I see that you seem to be serving contest.json's content directly, so I simply put it there.

If you mean to add checks for this feature or Enquire entries to change that, sorry, working on that.

@dungwinux
Copy link
Copy Markdown
Member

That's not how the config system work. Currently, it parses config while preserving as much as possible. That means it only read white-listed properties. See in src/util/config/contestConfig.js for more details.

@minhducsun2002
Copy link
Copy Markdown
Contributor Author

Should work properly now.

@enbugging
Copy link
Copy Markdown
Contributor

Hmm, anyone?

@dungwinux
Copy link
Copy Markdown
Member

dungwinux commented Jun 7, 2021

Hmm, anyone?

@MegumiTadokoro Feel free to contribute, at least after rebasing or resolving conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants