Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some scenarios, it is necessary to ignore the structure length.
One such example is Tarantool. Due to the specifics of the Lua language, a structure that has an empty value at the end (for example,
{0, nil, 1, 2, nil}) is truncated to the last non-nil value and becomes{0, nil, 1, 2}.More details are available in the Tarantool documentation.
Despite this behavior, the official Go module github.com/tarantool/go-tarantool/v2 still uses the
github.com/vmihailenco/msgpackmodule in the decoder (see here), which reports an error in such cases:msgpack: number of fields in array-encoded struct has changed.This PR introduces an option to ignore this error and also fixes decoding when the number of fields differs from what is defined in the struct.