Skip to content

Conversation

@kwsantiago
Copy link

@kwsantiago kwsantiago commented Sep 5, 2025

🍰 Pullrequest

Fix Naxxramas slime damage by using WMO ID instead of filename parsing. This replaces the fragile string-based detection with a proper ID check and removes the commented-out hackfix that was preventing all slime environmental damage.

Proof

  • Code compiles successfully with the changes
  • Changes follow the exact recommendation from issue reporter (@Wall-core)
  • Fix uses the same pattern as other rootWMO-> member accesses in the codebase

Issues

How2Test

  1. Test Naxxramas slime damage:

    • Enter Naxxramas (Grobbulus room has slime)
    • Stand in green slime
    • Verify you take environmental damage (should use liquid type 21)
  2. Test regular slime damage:

    • Go to any other zone with slime (e.g., certain caves)
    • Stand in slime
    • Verify you take environmental damage (should use liquid type 4)
  3. Verify the WMO fix:

    • Run vmap_extractor on game files
    • Check that Stratholme_raid.wmo is detected by ID 4489, not filename
    • Renamed copies of the file should NOT get Naxx slime type

Todo / Checklist

  • Replaced filename.find("Stratholme_raid") with rootWMO->RootWMOID == 4489 check
  • Removed commented slime damage hackfix from Player.cpp
  • Code compiles without errors
  • Changes are minimal
  • Needs in-game testing by reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Fix naxx slime

1 participant