Fix Mage partybots not reapplying Arcane Brilliance.

[mserajnik]

🍰 Pullrequest

This fixes Mage partybots not reapplying Arcane Brilliance unless it has expired on themselves.

As was pointed out, other party-wide buffs such as Prayer of Fortitude or Prayer of Spirit are cast again as soon as they drop off a single member and an argument could be made that that's not always desirable (because it's mana-inefficient).

However, I would argue that "always re-buffing" instead of "almost never re-buffing" is probably the better choice and with this PR, the behavior of Arcane Brilliance at least matches that of the other buffs. Ideally, this should be configurable in some way (e.g., have a toggle command to allow/disallow party-wide buffs so players can choose when they get used).

Proof

• None

Issues

• Fixes 🐛 [Bug] Partybots will not reapply Arcane Brilliance to other players unless they have expired on themselves #2400

How2Test

• Summon a Mage partybot that knows Arcane Brilliance
• Wait for it to cast Arcane Brilliance, then remove the buff from yourself
• Observe the Mage partybot casting Arcane Brilliance again (once he is finished drinking and has enough mana)

Todo / Checklist

• None

[gajet5]

https://github.com/vmangos/core/pull/2510/commits

[mserajnik]

@gajet5

Sorry, I missed your PR somehow; you should mark that it closes #2400.

[mserajnik]

I'm reopening this because @gajet5 closed his PR (#2510) and this is a tested fix for #2400.

[mserajnik]

No actual code changes in the force-push; I just updated this PR to be based on the latest development commit because when downloading the changes as patch it wasn't possible to git apply it anymore because the patch included the now renamed UNIT_STAT_ROOT in the surrounding lines of code:

(previous generated patch on the left, new patch after rebasing on the right)